perf(scene): make geometry edits incremental

Avoid full document, cache, and GPU rebuilds for entity deltas so add, delete, history, selection, and live polyline edits stay responsive on large drawings.
This commit is contained in:
Hakan Seven committed 2026-07-28 17:16:27 +03:00
1 parent 73b8dbe9d4
commit 05b044f367
32 files changed
+1936 -516

No files matched your search

+31 -3
View File
@@ -345,12 +345,21 @@ impl CadCommand for PlineCommand {
}
fn on_enter(&mut self) -> CmdResult {
// The committed vertices already live in the document; finalise it.
self.sync_live(false, true)
// Every landed vertex is already published into the live document
// entity. Finishing must only close its history/command state; replacing
// the identical polyline again would advance geometry_epoch and make
// large drawings do another cache/GPU patch for no visual change.
match self.live_handle {
Some(handle) => CmdResult::FinalizeLiveEntity(handle),
None => CmdResult::Cancel,
}
}
fn on_escape(&mut self) -> CmdResult {
self.sync_live(false, true)
match self.live_handle {
Some(handle) => CmdResult::FinalizeLiveEntity(handle),
None => CmdResult::Cancel,
}
}
fn wants_text_input(&self) -> bool {
@@ -483,4 +492,23 @@ mod tests {
_ => panic!("later segments should update the same live polyline"),
}
}
#[test]
fn finishing_live_polyline_does_not_publish_duplicate_update() {
let handle = Handle::new(42);
let mut enter = PlineCommand::new();
enter.live_handle = Some(handle);
assert!(matches!(
enter.on_enter(),
CmdResult::FinalizeLiveEntity(h) if h == handle
));
let mut escape = PlineCommand::new();
escape.live_handle = Some(handle);
assert!(matches!(
escape.on_escape(),
CmdResult::FinalizeLiveEntity(h) if h == handle
));
}
}