Complete 2D solid workflow

This commit is contained in:
ramox81 committed 2026-08-21 10:14:26 +03:00
1 parent 573ed3245e
commit 17dc0aff39
11 files changed
+257 -181

No files matched your search

+182 -118
View File
@@ -1,28 +1,35 @@
// SOLID entity — 2D filled quadrilateral (or triangle when p3 == p4).
//
// Wireframe: the 4 perimeter edges as RenderObject::Lines.
// Filled: two triangles on `fill_tris`, preserving the entity's full WCS
// plane both at top level and through block expansion. The scene
// keeps a separate 2-D HatchModel only for plot projection; screen
// rendering filters that flattened copy out.
// Filled: boundary triangles on `fill_tris`, plus the top and side faces for
// non-zero thickness. The full WCS plane is preserved both at top
// level and through block expansion. The scene keeps a separate 2-D
// HatchModel only for plot projection; screen rendering filters that
// flattened copy out.
// Grips: 4 corner grip points.
use acadrust::entities::Solid;
use crate::t;
use crate::command::EntityTransform;
use crate::entities::common::{edit_prop as edit, ro_prop as ro, square_grip};
use crate::entities::common::{edit_prop as edit, square_grip};
use crate::entities::traits::{Grippable, PropertyEditable, Transformable, RenderConvertible};
use crate::scene::convert::acad_to_render::{RenderEntity, RenderObject};
use crate::scene::model::object::{GripApply, GripDef, PropSection};
use crate::scene::model::wire_model::SnapHint;
fn dvec3(v: &acadrust::types::Vector3) -> glam::DVec3 {
glam::DVec3::new(v.x, v.y, v.z)
fn normal_tuple(solid: &Solid) -> (f64, f64, f64) {
let normal = glam::DVec3::new(solid.normal.x, solid.normal.y, solid.normal.z)
.normalize_or(glam::DVec3::Z);
(normal.x, normal.y, normal.z)
}
fn dvec3(v: [f64; 3]) -> glam::DVec3 {
glam::DVec3::from_array(v)
}
pub(crate) fn wcs_corners(solid: &Solid) -> [[f64; 3]; 4] {
let n = (solid.normal.x, solid.normal.y, solid.normal.z);
let n = normal_tuple(solid);
let w = |v: &acadrust::types::Vector3| {
let (x, y, z) = crate::scene::view::transform::ocs_point_to_wcs((v.x, v.y, v.z), n);
[x, y, z]
@@ -35,81 +42,108 @@ pub(crate) fn wcs_corners(solid: &Solid) -> [[f64; 3]; 4] {
]
}
/// Return a non-self-intersecting perimeter for either conventional DXF SOLID
/// Z-order or older/perimeter-ordered data. Prefer DXF order when both are
/// valid, but recover legacy solids whose 1-2-4-3 walk forms a bow-tie.
pub(crate) fn perimeter_indices(corners: &[[f64; 3]; 4]) -> [usize; 4] {
let p = |index: usize| glam::DVec3::from_array(corners[index]);
let edge = p(1) - p(0);
let mut normal = edge.cross(p(2) - p(0));
if normal.length_squared() < 1.0e-20 {
normal = edge.cross(p(3) - p(0));
}
if normal.length_squared() < 1.0e-20 {
return [0, 1, 3, 2];
}
let orient = |a: usize, b: usize, c: usize| {
(p(b) - p(a)).cross(p(c) - p(a)).dot(normal)
fn set_wcs_corner(solid: &mut Solid, index: usize, point: glam::DVec3) {
let n = normal_tuple(solid);
let (x, y, z) = crate::scene::view::transform::wcs_point_to_ocs(
(point.x, point.y, point.z),
n,
);
let corner = match index {
0 => &mut solid.first_corner,
1 => &mut solid.second_corner,
2 => &mut solid.third_corner,
3 => &mut solid.fourth_corner,
_ => return,
};
let segments_cross = |a: usize, b: usize, c: usize, d: usize| {
let ab_c = orient(a, b, c);
let ab_d = orient(a, b, d);
let cd_a = orient(c, d, a);
let cd_b = orient(c, d, b);
((ab_c > 0.0 && ab_d < 0.0) || (ab_c < 0.0 && ab_d > 0.0))
&& ((cd_a > 0.0 && cd_b < 0.0) || (cd_a < 0.0 && cd_b > 0.0))
};
let order_crosses = |order: [usize; 4]| {
segments_cross(order[0], order[1], order[2], order[3])
|| segments_cross(order[1], order[2], order[3], order[0])
};
let dxf = [0, 1, 3, 2];
let perimeter = [0, 1, 2, 3];
if order_crosses(dxf) && !order_crosses(perimeter) {
perimeter
} else {
dxf
corner.x = x;
corner.y = y;
corner.z = z;
}
fn push_edge(lines: &mut Vec<[f64; 3]>, start: [f64; 3], end: [f64; 3]) {
lines.extend([start, end, [f64::NAN; 3]]);
}
fn push_fan(triangles: &mut Vec<[f64; 3]>, points: &[[f64; 3]], reverse: bool) {
for index in 1..points.len() - 1 {
if reverse {
triangles.extend([points[0], points[index + 1], points[index]]);
} else {
triangles.extend([points[0], points[index], points[index + 1]]);
}
}
}
impl RenderConvertible for Solid {
fn to_render(&self, _document: &acadrust::CadDocument) -> Option<RenderEntity> {
// SOLID corners are OCS. Map them to WCS, then resolve either the DXF
// Z-order or legacy perimeter order before building edges and fill.
// SOLID corners are OCS and the last two are stored in Z order. Preserve
// that ordering exactly: it is part of the entity geometry and can
// intentionally describe a crossing shape.
let corners = wcs_corners(self);
let order = perimeter_indices(&corners);
let [p0, p1, p2, p3] = order.map(|index| corners[index]);
let pts = vec![
p0,
p1,
[f64::NAN; 3],
p1,
p2,
[f64::NAN; 3],
p2,
p3,
[f64::NAN; 3],
p3,
p0,
];
let dvp = |p: [f64; 3]| glam::DVec3::from_array(p);
let snap = corners
let base = if self.is_triangle() {
vec![corners[0], corners[1], corners[2]]
} else {
vec![corners[0], corners[1], corners[3], corners[2]]
};
let normal = glam::DVec3::new(self.normal.x, self.normal.y, self.normal.z)
.normalize_or(glam::DVec3::Z);
let extruded = self.thickness.abs() > 1.0e-10;
let top: Vec<[f64; 3]> = base
.iter()
.copied()
.map(|point| (dvp(point), SnapHint::Node))
.map(|point| {
(glam::DVec3::from_array(*point) + normal * self.thickness).to_array()
})
.collect();
// Fill the resolved perimeter as two triangles. For a triangle the last
// two points coincide and the second triangle degenerates harmlessly.
let fill_tris = vec![p0, p1, p2, p0, p2, p3];
let mut lines = Vec::new();
for index in 0..base.len() {
push_edge(&mut lines, base[index], base[(index + 1) % base.len()]);
}
if extruded {
for index in 0..top.len() {
push_edge(&mut lines, top[index], top[(index + 1) % top.len()]);
push_edge(&mut lines, base[index], top[index]);
}
}
let mut fill_tris = Vec::new();
push_fan(&mut fill_tris, &base, false);
if extruded {
push_fan(&mut fill_tris, &top, true);
for index in 0..base.len() {
let next = (index + 1) % base.len();
fill_tris.extend([
base[index],
base[next],
top[next],
base[index],
top[next],
top[index],
]);
}
}
let mut snap_points = base.clone();
if extruded {
snap_points.extend(top.iter().copied());
}
let snap = snap_points
.iter()
.copied()
.map(|point| (dvec3(point), SnapHint::Node))
.collect();
let pick_tris = if extruded {
fill_tris.clone()
} else {
Vec::new()
};
Some(RenderEntity {
pick_tris: Vec::new(),
object: RenderObject::Lines(pts),
pick_tris,
object: RenderObject::Lines(lines),
snap_pts: snap,
tangent_geoms: vec![],
key_vertices: corners.to_vec(),
key_vertices: snap_points,
fill_tris,
})
}
@@ -117,58 +151,51 @@ impl RenderConvertible for Solid {
impl Grippable for Solid {
fn grips(&self) -> Vec<GripDef> {
let corners = wcs_corners(self);
vec![
square_grip(0, dvec3(&self.first_corner)),
square_grip(1, dvec3(&self.second_corner)),
square_grip(2, dvec3(&self.third_corner)),
square_grip(3, dvec3(&self.fourth_corner)),
square_grip(0, dvec3(corners[0])),
square_grip(1, dvec3(corners[1])),
square_grip(2, dvec3(corners[2])),
square_grip(3, dvec3(corners[3])),
]
}
fn apply_grip(&mut self, grip_id: usize, apply: GripApply) {
let corner = match grip_id {
0 => &mut self.first_corner,
1 => &mut self.second_corner,
2 => &mut self.third_corner,
3 => &mut self.fourth_corner,
_ => return,
let Some(current) = wcs_corners(self).get(grip_id).copied() else {
return;
};
match apply {
GripApply::Translate(d) => {
corner.x += d.x as f64;
corner.y += d.y as f64;
corner.z += d.z as f64;
}
GripApply::Absolute(p) => {
corner.x = p.x as f64;
corner.y = p.y as f64;
corner.z = p.z as f64;
}
}
let point = match apply {
GripApply::Translate(delta) => dvec3(current) + delta,
GripApply::Absolute(point) => point,
};
set_wcs_corner(self, grip_id, point);
}
}
impl PropertyEditable for Solid {
fn geometry_properties(&self, _text_style_names: &[String]) -> Vec<PropSection> {
// Elevation is the OCS Z shared by the planar corners (no dedicated
// field on the entity); reported from the first corner's Z.
let corners = wcs_corners(self);
let elevation = self.first_corner.z;
vec![PropSection {
title: t!("Geometry").into_owned(),
props: vec![
edit(t!("Point 1 X").as_ref(), "sl_p1x", self.first_corner.x),
edit(t!("Point 1 Y").as_ref(), "sl_p1y", self.first_corner.y),
edit(t!("Point 1 Z").as_ref(), "sl_p1z", self.first_corner.z),
edit(t!("Point 2 X").as_ref(), "sl_p2x", self.second_corner.x),
edit(t!("Point 2 Y").as_ref(), "sl_p2y", self.second_corner.y),
edit(t!("Point 2 Z").as_ref(), "sl_p2z", self.second_corner.z),
edit(t!("Point 3 X").as_ref(), "sl_p3x", self.third_corner.x),
edit(t!("Point 3 Y").as_ref(), "sl_p3y", self.third_corner.y),
edit(t!("Point 3 Z").as_ref(), "sl_p3z", self.third_corner.z),
edit(t!("Point 4 X").as_ref(), "sl_p4x", self.fourth_corner.x),
edit(t!("Point 4 Y").as_ref(), "sl_p4y", self.fourth_corner.y),
edit(t!("Point 4 Z").as_ref(), "sl_p4z", self.fourth_corner.z),
ro(t!("Elevation").as_ref(), "sl_elev", format!("{:.4}", elevation)),
edit(t!("Point 1 X").as_ref(), "sl_p1x", corners[0][0]),
edit(t!("Point 1 Y").as_ref(), "sl_p1y", corners[0][1]),
edit(t!("Point 1 Z").as_ref(), "sl_p1z", corners[0][2]),
edit(t!("Point 2 X").as_ref(), "sl_p2x", corners[1][0]),
edit(t!("Point 2 Y").as_ref(), "sl_p2y", corners[1][1]),
edit(t!("Point 2 Z").as_ref(), "sl_p2z", corners[1][2]),
edit(t!("Point 3 X").as_ref(), "sl_p3x", corners[2][0]),
edit(t!("Point 3 Y").as_ref(), "sl_p3y", corners[2][1]),
edit(t!("Point 3 Z").as_ref(), "sl_p3z", corners[2][2]),
edit(t!("Point 4 X").as_ref(), "sl_p4x", corners[3][0]),
edit(t!("Point 4 Y").as_ref(), "sl_p4y", corners[3][1]),
edit(t!("Point 4 Z").as_ref(), "sl_p4z", corners[3][2]),
edit(t!("Elevation").as_ref(), "sl_elev", elevation),
edit(t!("Thickness").as_ref(), "sl_thickness", self.thickness),
edit(t!("Normal X").as_ref(), "sl_normal_x", self.normal.x),
edit(t!("Normal Y").as_ref(), "sl_normal_y", self.normal.y),
edit(t!("Normal Z").as_ref(), "sl_normal_z", self.normal.z),
],
}]
}
@@ -177,19 +204,56 @@ impl PropertyEditable for Solid {
let Ok(v) = value.trim().parse::<f64>() else {
return;
};
let point_field = match field {
"sl_p1x" => Some((0, 0)),
"sl_p1y" => Some((0, 1)),
"sl_p1z" => Some((0, 2)),
"sl_p2x" => Some((1, 0)),
"sl_p2y" => Some((1, 1)),
"sl_p2z" => Some((1, 2)),
"sl_p3x" => Some((2, 0)),
"sl_p3y" => Some((2, 1)),
"sl_p3z" => Some((2, 2)),
"sl_p4x" => Some((3, 0)),
"sl_p4y" => Some((3, 1)),
"sl_p4z" => Some((3, 2)),
_ => None,
};
if let Some((point_index, component)) = point_field {
let mut point = dvec3(wcs_corners(self)[point_index]);
point[component] = v;
set_wcs_corner(self, point_index, point);
return;
}
match field {
"sl_p1x" => self.first_corner.x = v,
"sl_p1y" => self.first_corner.y = v,
"sl_p1z" => self.first_corner.z = v,
"sl_p2x" => self.second_corner.x = v,
"sl_p2y" => self.second_corner.y = v,
"sl_p2z" => self.second_corner.z = v,
"sl_p3x" => self.third_corner.x = v,
"sl_p3y" => self.third_corner.y = v,
"sl_p3z" => self.third_corner.z = v,
"sl_p4x" => self.fourth_corner.x = v,
"sl_p4y" => self.fourth_corner.y = v,
"sl_p4z" => self.fourth_corner.z = v,
"sl_elev" => {
let delta = v - self.first_corner.z;
self.first_corner.z += delta;
self.second_corner.z += delta;
self.third_corner.z += delta;
self.fourth_corner.z += delta;
}
"sl_thickness" => self.thickness = v,
"sl_normal_x" | "sl_normal_y" | "sl_normal_z" => {
let world = wcs_corners(self);
let mut normal = glam::DVec3::new(self.normal.x, self.normal.y, self.normal.z);
match field {
"sl_normal_x" => normal.x = v,
"sl_normal_y" => normal.y = v,
"sl_normal_z" => normal.z = v,
_ => {}
}
if normal.length_squared() > 1.0e-20 {
normal = normal.normalize();
self.normal.x = normal.x;
self.normal.y = normal.y;
self.normal.z = normal.z;
for (index, point) in world.into_iter().enumerate() {
set_wcs_corner(self, index, dvec3(point));
}
}
}
_ => {}
}
}