Add Graphic Attributes palette toggle and persistence

src/app/update/dialog.rs

@@ -130,7 +130,6 @@ fn close_fill_boundary(entity: &mut acadrust::EntityType) -> bool {
     }
 }
 
-#[derive(Clone)]
 struct ConcreteGraphicAttributes {
     color: acadrust::types::Color,
     linetype: String,
@@ -212,10 +211,11 @@ fn valid_layer_name(name: &str) -> bool {
     !name.is_empty()
         && name.chars().count() <= 255
         && !name.chars().any(|character| {
-            matches!(
-                character,
-                '<' | '>' | '/' | '\\' | '"' | ':' | ';' | '?' | '*' | '|' | '=' | '`'
-            )
+            character.is_control()
+                || matches!(
+                    character,
+                    '<' | '>' | '/' | '\\' | '"' | ':' | ';' | '?' | '*' | '|' | '=' | '`'
+                )
         })
 }
 
@@ -918,7 +918,10 @@ impl OpenCADStudio {
     }
 
     pub(super) fn on_line_linetype_scale(&mut self, scale: f64) -> iced::Task<Message> {
-        let scale = ((scale * 10.0).round() / 10.0).clamp(0.1, 1000.0);
+        let Some(scale) = crate::ui::window::graphic_attributes::normalized_linetype_scale(scale)
+        else {
+            return iced::Task::none();
+        };
         let i = self.active_tab;
         let selected = self.tabs[i].scene.selected_handles_in_order();
         if selected.is_empty() {
@@ -1595,8 +1598,12 @@ impl OpenCADStudio {
                     }
                     PanelId::GraphicAttributes => {
                         self.show_graphic_attributes = false;
+                        self.ribbon.set_graphic_attributes(false);
                         self.graphic_attributes_header_menu_open = false;
                         self.graphic_attribute_menu_open = false;
+                        self.gradient_editor = None;
+                        self.hatch_editor_handles = None;
+                        self.save_config();
                     }
                 }
                 if self.dock_expanded == Some(id) {
@@ -2588,6 +2595,17 @@ mod tests {
                 .abs()
                 < f64::EPSILON
         );
+        let _ = app.update(Message::LineLinetypeScaleChanged(f64::NAN));
+        assert_eq!(
+            app.tabs[i]
+                .scene
+                .document
+                .get_entity(line)
+                .expect("line")
+                .common()
+                .linetype_scale,
+            2.5
+        );
         let _ = app.update(Message::LineLinetypeScaleChanged(1.2000000000000002));
         assert_eq!(
             app.tabs[i]
@@ -2817,6 +2835,14 @@ mod tests {
         let _ = app.on_line_lineweight(acadrust::types::LineWeight::Value(35));
         let _ = app.on_line_transparency(acadrust::types::Transparency::from_percent(0.3));
 
+        let _ = app.create_graphic_attributes_layer("Invalid\nLayer");
+        assert!(app.tabs[i]
+            .scene
+            .document
+            .layers
+            .get("Invalid\nLayer")
+            .is_none());
+
         let _ = app.update(Message::GraphicAttributesCreateLayer);
         assert_eq!(
             app.tabs[i]

src/app/update/file.rs

@@ -1086,6 +1086,7 @@ impl OpenCADStudio {
                 dock.ensure_settings();
                 dock
             },
+            show_graphic_attributes: self.show_graphic_attributes,
             annotation_auto_scale: self.annotation_auto_scale,
             ribbon: crate::app::config::RibbonConfig {
                 collapse: self.ribbon.collapse_mode(),
@@ -1144,6 +1145,9 @@ impl OpenCADStudio {
         let mut dock = cfg.dock;
         dock.ensure_settings();
         self.dock = dock;
+        self.show_graphic_attributes = cfg.show_graphic_attributes;
+        self.ribbon
+            .set_graphic_attributes(self.show_graphic_attributes);
         self.annotation_auto_scale = cfg.annotation_auto_scale.clamp(-4, 4);
         self.ribbon.set_collapse_mode(cfg.ribbon.collapse);
         self.plot_dialog = cfg.plot;

src/app/update/mod.rs

@@ -4229,6 +4229,19 @@ impl OpenCADStudio {
                 self.ribbon.set_properties(self.show_properties);
                 Task::none()
             }
+            Message::ToggleGraphicAttributes => {
+                self.show_graphic_attributes ^= true;
+                self.ribbon
+                    .set_graphic_attributes(self.show_graphic_attributes);
+                if !self.show_graphic_attributes {
+                    self.graphic_attributes_header_menu_open = false;
+                    self.graphic_attribute_menu_open = false;
+                    self.gradient_editor = None;
+                    self.hatch_editor_handles = None;
+                }
+                self.save_config();
+                Task::none()
+            }
             Message::ToggleFileTabs => {
                 self.show_file_tabs ^= true;
                 self.ribbon.set_file_tabs(self.show_file_tabs);
@@ -11220,6 +11233,30 @@ mod prop_pointer_tests {
     }
 }
 
+#[cfg(test)]
+mod graphic_attributes_visibility_tests {
+    use super::Message;
+    use crate::app::OpenCADStudio;
+
+    #[test]
+    fn graphic_attributes_starts_hidden_and_toggle_is_persisted() {
+        let mut app = OpenCADStudio::new_for_test();
+        app.apply_config(crate::app::config::AppConfig::default());
+        assert!(!app.show_graphic_attributes);
+        assert!(!app.ribbon.show_graphic_attributes);
+
+        let _ = app.update(Message::ToggleGraphicAttributes);
+        assert!(app.show_graphic_attributes);
+        assert!(app.ribbon.show_graphic_attributes);
+        assert!(app.current_config().show_graphic_attributes);
+
+        let _ = app.update(Message::ToggleGraphicAttributes);
+        assert!(!app.show_graphic_attributes);
+        assert!(!app.ribbon.show_graphic_attributes);
+        assert!(!app.current_config().show_graphic_attributes);
+    }
+}
+
 #[cfg(test)]
 mod free_text_entry_tests {
     //! The free-form text prompts (table cell content, TEXT / MTEXT bodies)