feat(dgn-ls): dash walls from start + fix wall connector and cap identity

DET pipe walls now carry the stroke pattern (dash_from_start), which
tiles from each wall's own start vertex and skips the A-type end
alignment that was force-lighting a solid dash under the end symbol.

Two rendering fixes on top:
- Dedup the host polyline's vertices before offsetting the walls. Some
  DGN pipe polylines carry trailing duplicate end vertices; a zero-length
  segment gave offset_xy a degenerate normal, leaving that vertex
  un-offset and folding the wall down to the centre line. The two walls'
  fold segments met at the centre and drew a spurious line linking them.
- Re-key the symbol (end circle / half-ellipse) wires to the host handle
  so the whole pipe picks and selects as one entity instead of the
  symbols acting as separate phantom entities.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
Hakan SevenandClaude Opus 4.8 committed 2026-07-17 01:49:18 +03:00
1 parent 765e6606e2
commit 48e6d0d553
42 files changed
+124 -8

No files matched your search

+2
View File
@@ -186,6 +186,7 @@ impl CadCommand for AlignedDimensionCommand {
let p1 = p1.as_vec3();
let p2 = p2.as_vec3();
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimaligned_preview".into(),
points: vec![[p1.x, p1.y, p1.z], [p2.x, p2.y, p2.z]],
@@ -233,6 +234,7 @@ fn preview_aligned(p1: DVec3, p2: DVec3, dim_pt: DVec3) -> WireModel {
let d1 = d1.as_vec3();
let d2 = d2.as_vec3();
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimaligned_preview".into(),
points: vec![
+1
View File
@@ -130,6 +130,7 @@ fn v3(pt: DVec3) -> Vector3 {
fn preview_wire(points: Vec<Vec3>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimangular_preview".to_string(),
points: points.into_iter().map(|p| [p.x, p.y, p.z]).collect(),
+1
View File
@@ -180,6 +180,7 @@ fn v3(p: DVec3) -> Vector3 {
fn preview_line(a: Vec3, b: Vec3) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimdia_preview".into(),
points: vec![[a.x, a.y, a.z], [b.x, b.y, b.z]],
+1
View File
@@ -179,6 +179,7 @@ impl CadCommand for DimBaselineCommand {
let dim_line_pt2 = dim_line_pt2.as_vec3();
let pt = pt.as_vec3();
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimbase_preview".into(),
points: vec![
+1
View File
@@ -159,6 +159,7 @@ impl CadCommand for DimContinueCommand {
let dim_line_pt = p1 + perp * (dim_line_perp - p1.dot(perp));
let dim_line_pt2 = pt + perp * (dim_line_perp - pt.dot(perp));
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimcont_preview".into(),
points: vec![
+1
View File
@@ -85,6 +85,7 @@ impl CadCommand for DimJogLineCommand {
}
let d = 0.3_f32;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimjog_preview".into(),
// Jog zigzag in the XY drawing plane (Z is elevation, ~0). The old
+1
View File
@@ -100,6 +100,7 @@ impl CadCommand for DimTeditCommand {
}
let d = 0.2_f32;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimtedit_preview".into(),
// Marker box in the XY drawing plane (Z is elevation, ~0). The old
+1
View File
@@ -163,6 +163,7 @@ fn preview_wire(pts: &[Vec3]) -> WireModel {
points.push([w2.x, w2.y, w2.z]);
}
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "leader_preview".into(),
points,
+1
View File
@@ -218,6 +218,7 @@ fn v3(pt: DVec3) -> Vector3 {
fn preview_wire(points: Vec<DVec3>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimlinear_preview".to_string(),
points: points
+1
View File
@@ -150,6 +150,7 @@ fn preview_wire(pts: &[Vec3]) -> WireModel {
points.push([w2.x, w2.y, w2.z]);
}
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "mleader_preview".into(),
points,
+1
View File
@@ -458,6 +458,7 @@ impl CadCommand for MLeaderCollectCommand {
fn preview_wire(pts: &[Vec3]) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "mleader_edit_preview".into(),
points: pts.iter().map(|p| [p.x, p.y, p.z]).collect(),
+1
View File
@@ -121,6 +121,7 @@ fn ordinate_elbow(feature: DVec3, leader: DVec3, is_x: bool) -> DVec3 {
fn preview_wire(points: Vec<Vec3>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimordinate_preview".into(),
points: points.into_iter().map(|p| [p.x, p.y, p.z]).collect(),
+1
View File
@@ -90,6 +90,7 @@ impl CadCommand for QdimCommand {
}
let d = 0.5_f32;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "qdim_preview".into(),
points: vec![[pt.x - d * 3.0, pt.y, pt.z], [pt.x + d * 3.0, pt.y, pt.z]],
+1
View File
@@ -185,6 +185,7 @@ fn v3(pt: DVec3) -> Vector3 {
fn preview_wire(points: Vec<Vec3>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dimradius_preview".to_string(),
points: points.into_iter().map(|p| [p.x, p.y, p.z]).collect(),
+1
View File
@@ -139,6 +139,7 @@ impl CadCommand for TableCommand {
let y = pt.y;
let z = pt.z;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "table_preview".into(),
points: vec![
+1
View File
@@ -84,6 +84,7 @@ impl CadCommand for ToleranceCommand {
}
let d = 0.15_f32;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "tolerance_preview".into(),
points: vec![
+1
View File
@@ -160,6 +160,7 @@ impl CadCommand for AttdefCommand {
// Show a small cross at the insertion point.
let d = 0.15_f32;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "attdef_preview".into(),
points: vec![
+1
View File
@@ -136,6 +136,7 @@ impl CadCommand for MlineCommand {
.collect();
pts.push([pt.x, pt.y, pt.z]);
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "mline_preview".into(),
points: pts,
+1
View File
@@ -108,6 +108,7 @@ impl CadCommand for ImageCommand {
let p3 = [origin.x, origin.y + world_height, origin.z];
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "image_preview".into(),
points: vec![p0, p1, p2, p3, p0],
+2
View File
@@ -84,6 +84,7 @@ impl CadCommand for RayCommand {
let dir = (pt - base).normalize_or_zero();
let far = base + dir * DISPLAY_EXTENT;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "ray_preview".into(),
points: vec![[base.x, base.y, base.z], [far.x, far.y, far.z]],
@@ -175,6 +176,7 @@ impl CadCommand for XLineCommand {
let far_pos = base + dir * DISPLAY_EXTENT;
let far_neg = base - dir * DISPLAY_EXTENT;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "xline_preview".into(),
points: vec![
+1
View File
@@ -89,6 +89,7 @@ impl CadCommand for RevCloudCommand {
self.points[0].z as f32,
]);
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "revcloud_preview".into(),
points: preview_pts,
+2
View File
@@ -114,6 +114,7 @@ impl CadCommand for WipeoutCommand {
let min = p1.min(pt);
let max = p1.max(pt);
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "wipeout_preview".into(),
points: vec![
@@ -156,6 +157,7 @@ impl CadCommand for WipeoutCommand {
self.poly_pts[0].z as f32,
]);
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "wipeout_poly_preview".into(),
points: pts,
+1
View File
@@ -69,6 +69,7 @@ impl CadCommand for AreaCommand {
pts.push(f(pt));
pts.push(f(self.points[0]));
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "area_preview".into(),
points: pts,
+1
View File
@@ -63,6 +63,7 @@ impl CadCommand for DistCommand {
let p1 = self.first?;
// The preview wire is purely visual, so f32 vertices are fine here.
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "dist_preview".into(),
points: vec![
+1
View File
@@ -67,6 +67,7 @@ impl MeasureGeomCommand {
/// Build a cyan preview wire connecting the picked points and the cursor.
fn preview_wire(name: &str, pts: Vec<[f32; 3]>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.to_string(),
points: pts,
+1
View File
@@ -3059,6 +3059,7 @@ fn collect_runs(pts: &[[f64; 2]], take: &dyn Fn([f64; 2]) -> bool, out: &mut Vec
/// Build a preview wire from a NaN-break point list.
fn preview_wire(points: Vec<[f32; 3]>, color: [f32; 4], name: &str) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.into(),
points,
+1
View File
@@ -81,6 +81,7 @@ impl CadCommand for MviewCommand {
let pt = pt.as_vec3();
let c1 = self.corner1?;
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "mview_preview".to_string(),
points: vec![
+1
View File
@@ -305,6 +305,7 @@ inventory::submit!(crate::command::CommandRegistration {
fn wire(name: &str, points: Vec<[f32; 3]>) -> WireModel {
WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.into(),
points,
+1
View File
@@ -48,6 +48,7 @@ impl CadCommand for PlotWindowCommand {
let p1 = self.p1?.as_vec3();
// Draw the selection rectangle.
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "plotwindow_preview".into(),
points: vec![
+1
View File
@@ -65,6 +65,7 @@ impl CadCommand for ZoomWindowCommand {
let max = p1.max(pt);
// Draw a rectangle preview
Some(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: "zoom_window_preview".into(),
points: vec![