1b-agent/OneCAD-Draft
1
0 Fork 0
forked from 1b-agent/opencadstudio-upstream
Code Pull Requests Activity

refactor(viewport): unify content-viewport clipping on the stencil path

Browse Source 
Rectangular paper viewports now go through the same GPU stencil clip as
non-rectangular ones: viewport_clip_boundary_ndc returns the four rect
corners (a full-target mask) instead of nothing, so the render path has
no rect/non-rect special case — every content viewport carries a clip
boundary and draws with stencil reference 0xFF.

With a single clip path, the old per-wire / -image / -wipeout scissor
mechanism is fully dead and removed: compute_*_scissors, the
*_pixel_scissors buffers, the project_scissor helper, the per-pass
set_scissor_rect blocks, the vp_scissor field threaded through
WireModel / ImageModel / HatchModel and their GPU mirrors (WireGpu /
ImageGpu / WipeoutGpu / HatchWebGpu), from_run's scissor parameter, the
scissor grouping in build_wire_buffers, and the is_arena_eligible gate.
Net -245 lines across 54 files.

Rectangular viewports still clip exactly via their own render rectangle;
the stencil mask is a redundant full-target no-op there, kept only so
the clip code path stays uniform. XCLIP keeps its CPU wire clip.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
Hakan SevenandClaude Opus 4.8 committed 2026-07-20 11:06:28 +03:00
1 parent c97c2a8250
commit 626e8091f7
54 files changed
+32 -277
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/modules/annotate/aligned_dim.rs
-2
View File
@@ -206,7 +206,6 @@ impl CadCommand for AlignedDimensionCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
@@ -267,7 +266,6 @@ fn preview_aligned(p1: DVec3, p2: DVec3, dim_pt: DVec3) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/angular_dim.rs
-1
View File
@@ -150,7 +150,6 @@ fn preview_wire(points: Vec<Vec3>) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/diameter_dim.rs
-1
View File
@@ -200,7 +200,6 @@ fn preview_line(a: Vec3, b: Vec3) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/dim_baseline.rs
-1
View File
@@ -208,7 +208,6 @@ impl CadCommand for DimBaselineCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/dim_continue.rs
-1
View File
@@ -188,7 +188,6 @@ impl CadCommand for DimContinueCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/dimjogline.rs
-1
View File
@@ -113,7 +113,6 @@ impl CadCommand for DimJogLineCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/dimtedit.rs
-1
View File
@@ -129,7 +129,6 @@ impl CadCommand for DimTeditCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/leader_cmd.rs
-1
View File
@@ -183,7 +183,6 @@ fn preview_wire(pts: &[Vec3]) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/linear_dim.rs
-1
View File
@@ -241,7 +241,6 @@ fn preview_wire(points: Vec<DVec3>) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/mleader_cmd.rs
-1
View File
@@ -170,7 +170,6 @@ fn preview_wire(pts: &[Vec3]) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/mleader_edit.rs
-1
View File
@@ -478,7 +478,6 @@ fn preview_wire(pts: &[Vec3]) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/ordinate_dim.rs
-1
View File
@@ -141,7 +141,6 @@ fn preview_wire(points: Vec<Vec3>) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/qdim.rs
-1
View File
@@ -110,7 +110,6 @@ impl CadCommand for QdimCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/radius_dim.rs
-1
View File
@@ -205,7 +205,6 @@ fn preview_wire(points: Vec<Vec3>) -> WireModel {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
}
src/modules/annotate/table_cmd.rs
-1
View File
@@ -168,7 +168,6 @@ impl CadCommand for TableCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})
src/modules/annotate/tolerance_cmd.rs
-1
View File
@@ -110,7 +110,6 @@ impl CadCommand for ToleranceCommand {
key_vertices: vec![],
aabb: WireModel::UNBOUNDED_AABB,
plinegen: true,
vp_scissor: None,
fill_tris: vec![],
fill_tris_low: Vec::new(),
})