forked from 1b-agent/opencadstudio-upstream
merge: TEXTEDIT command + TEXTEDITMODE sysvar (#130)
Merge PR #130 (KarimJerbi) and resolve review findings: - Conflict (settings.rs): keep current persisted-settings layout, append texteditmode field. - Conflict (command/mod.rs): keep both new CmdResult variants — main's live-entity ops and the PR's text-edit suspend/resume. - Bug: invalid TEXTEDITMODE value no longer aborts via the Measurement arm; it now re-prompts with the error and stays active. - Dedup: single parse_texteditmode() helper replaces the value parsing duplicated across commands.rs, settings.rs and textedit.rs. - Strip trailing whitespace. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
commit
8c48233dcf
11 files changed
+399
-14
No files matched your search
@@ -23,6 +23,7 @@ pub mod qdim;
|
||||
pub mod radius_dim;
|
||||
pub mod table_cmd;
|
||||
pub mod text;
|
||||
pub mod textedit;
|
||||
pub mod tolerance_cmd;
|
||||
|
||||
use crate::modules::{CadModule, RibbonGroup, RibbonItem, StyleKey};
|
||||
|
||||
@@ -0,0 +1,253 @@
|
||||
// TEXTEDIT — edit multiline text, single-line text, or dimension text in-place.
|
||||
//
|
||||
// Workflow:
|
||||
// 1. Enters a loop prompting to select an annotation object.
|
||||
// 2. Accepts keyword options: Undo (to revert the last edit) and Mode (to switch Single/Multiple).
|
||||
// 3. In Multiple mode (default), editing an object suspends the command, opens the editor,
|
||||
// and when closed, resumes the command loop.
|
||||
// 4. In Single mode, editing an object exits the command immediately.
|
||||
|
||||
use acadrust::Handle;
|
||||
use glam::Vec3;
|
||||
|
||||
use crate::command::{CadCommand, CmdResult};
|
||||
|
||||
/// Parse a TEXTEDITMODE value. Accepts `0`/`m`/`multiple`/`false` (Multiple → false)
|
||||
/// and `1`/`s`/`single`/`true` (Single → true), case-insensitive. Returns `None`
|
||||
/// for anything else so callers can re-prompt or report the error.
|
||||
pub fn parse_texteditmode(s: &str) -> Option<bool> {
|
||||
match s.trim().to_lowercase().as_str() {
|
||||
"0" | "m" | "multiple" | "false" => Some(false),
|
||||
"1" | "s" | "single" | "true" => Some(true),
|
||||
_ => None,
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
|
||||
pub enum Step {
|
||||
PickObject,
|
||||
EnterMode,
|
||||
}
|
||||
|
||||
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
|
||||
pub enum TextEditMode {
|
||||
Single,
|
||||
Multiple,
|
||||
}
|
||||
|
||||
pub struct TexteditCommand {
|
||||
mode: TextEditMode,
|
||||
edit_count: usize,
|
||||
step: Step,
|
||||
}
|
||||
|
||||
impl TexteditCommand {
|
||||
pub fn new(texteditmode: bool) -> Self {
|
||||
let mode = if texteditmode {
|
||||
TextEditMode::Single
|
||||
} else {
|
||||
TextEditMode::Multiple
|
||||
};
|
||||
Self {
|
||||
mode,
|
||||
edit_count: 0,
|
||||
step: Step::PickObject,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl CadCommand for TexteditCommand {
|
||||
fn name(&self) -> &'static str {
|
||||
"TEXTEDIT"
|
||||
}
|
||||
|
||||
fn prompt(&self) -> String {
|
||||
match self.step {
|
||||
Step::PickObject => {
|
||||
if self.edit_count == 0 {
|
||||
"TEXTEDIT Select an annotation object or [Undo Mode]:".to_string()
|
||||
} else {
|
||||
"TEXTEDIT Select an annotation object or [Undo Mode] <exit>:".to_string()
|
||||
}
|
||||
}
|
||||
Step::EnterMode => {
|
||||
format!(
|
||||
"TEXTEDIT Enter text edit mode [Single/Multiple] <{}>:",
|
||||
match self.mode {
|
||||
TextEditMode::Single => "Single",
|
||||
TextEditMode::Multiple => "Multiple",
|
||||
}
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn needs_entity_pick(&self) -> bool {
|
||||
self.step == Step::PickObject
|
||||
}
|
||||
|
||||
fn on_entity_pick(&mut self, handle: Handle, _pt: Vec3) -> CmdResult {
|
||||
if handle.is_null() {
|
||||
return CmdResult::NeedPoint;
|
||||
}
|
||||
CmdResult::SuspendForTextEdit { handle }
|
||||
}
|
||||
|
||||
fn wants_text_input(&self) -> bool {
|
||||
true
|
||||
}
|
||||
|
||||
fn on_text_input(&mut self, text: &str) -> Option<CmdResult> {
|
||||
let text = text.trim();
|
||||
match self.step {
|
||||
Step::PickObject => {
|
||||
if text.is_empty() {
|
||||
if self.edit_count > 0 {
|
||||
return Some(CmdResult::Cancel);
|
||||
} else {
|
||||
return Some(CmdResult::NeedPoint);
|
||||
}
|
||||
}
|
||||
|
||||
let lower = text.to_lowercase();
|
||||
if lower == "u" || lower == "undo" {
|
||||
if self.edit_count > 0 {
|
||||
self.edit_count -= 1;
|
||||
return Some(CmdResult::UndoDocument);
|
||||
} else {
|
||||
return Some(CmdResult::NeedPoint);
|
||||
}
|
||||
} else if lower == "m" || lower == "mode" {
|
||||
self.step = Step::EnterMode;
|
||||
return Some(CmdResult::NeedPoint);
|
||||
}
|
||||
|
||||
Some(CmdResult::NeedPoint)
|
||||
}
|
||||
Step::EnterMode => {
|
||||
if text.is_empty() {
|
||||
self.step = Step::PickObject;
|
||||
return Some(CmdResult::NeedPoint);
|
||||
}
|
||||
|
||||
let lower = text.to_lowercase();
|
||||
if lower == "s" || lower == "single" || lower == "1" {
|
||||
self.mode = TextEditMode::Single;
|
||||
self.step = Step::PickObject;
|
||||
} else if lower == "m" || lower == "multiple" || lower == "0" {
|
||||
self.mode = TextEditMode::Multiple;
|
||||
self.step = Step::PickObject;
|
||||
}
|
||||
|
||||
Some(CmdResult::NeedPoint)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn on_point(&mut self, _pt: Vec3) -> CmdResult {
|
||||
CmdResult::NeedPoint
|
||||
}
|
||||
|
||||
fn on_enter(&mut self) -> CmdResult {
|
||||
match self.step {
|
||||
Step::PickObject => {
|
||||
if self.edit_count > 0 {
|
||||
CmdResult::Cancel
|
||||
} else {
|
||||
CmdResult::NeedPoint
|
||||
}
|
||||
}
|
||||
Step::EnterMode => {
|
||||
self.step = Step::PickObject;
|
||||
CmdResult::NeedPoint
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn on_escape(&mut self) -> CmdResult {
|
||||
CmdResult::Cancel
|
||||
}
|
||||
|
||||
fn on_editor_closed(&mut self, committed: bool) -> CmdResult {
|
||||
if committed {
|
||||
self.edit_count += 1;
|
||||
}
|
||||
|
||||
match self.mode {
|
||||
TextEditMode::Single => CmdResult::Cancel,
|
||||
TextEditMode::Multiple => CmdResult::NeedPoint,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub struct TexteditmodeCommand {
|
||||
current: bool,
|
||||
/// Set when the last value entry was unrecognized, so the next prompt
|
||||
/// leads with the error instead of silently re-asking.
|
||||
invalid: bool,
|
||||
}
|
||||
|
||||
impl TexteditmodeCommand {
|
||||
pub fn new(current: bool) -> Self {
|
||||
Self {
|
||||
current,
|
||||
invalid: false,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl CadCommand for TexteditmodeCommand {
|
||||
fn name(&self) -> &'static str {
|
||||
"TEXTEDITMODE"
|
||||
}
|
||||
|
||||
fn prompt(&self) -> String {
|
||||
let v = if self.current { 1 } else { 0 };
|
||||
let prefix = if self.invalid {
|
||||
"Requires 0 OR 1 OR MULTIPLE OR SINGLE. "
|
||||
} else {
|
||||
""
|
||||
};
|
||||
format!("{prefix}TEXTEDITMODE Enter new value for TEXTEDITMODE <{v}>:")
|
||||
}
|
||||
|
||||
fn wants_text_input(&self) -> bool {
|
||||
true
|
||||
}
|
||||
|
||||
fn on_text_input(&mut self, text: &str) -> Option<CmdResult> {
|
||||
let text = text.trim();
|
||||
if text.is_empty() {
|
||||
return Some(CmdResult::Cancel);
|
||||
}
|
||||
|
||||
match parse_texteditmode(text) {
|
||||
Some(v) => Some(CmdResult::SetTexteditMode(v)),
|
||||
// Unrecognized value: stay in the command and re-prompt with the
|
||||
// error, rather than aborting via the Measurement arm.
|
||||
None => {
|
||||
self.invalid = true;
|
||||
Some(CmdResult::NeedPoint)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn on_point(&mut self, _pt: Vec3) -> CmdResult {
|
||||
CmdResult::NeedPoint
|
||||
}
|
||||
|
||||
fn on_enter(&mut self) -> CmdResult {
|
||||
CmdResult::Cancel
|
||||
}
|
||||
|
||||
fn on_escape(&mut self) -> CmdResult {
|
||||
CmdResult::Cancel
|
||||
}
|
||||
|
||||
fn dyn_field(&self) -> crate::command::DynField {
|
||||
crate::command::DynField::Scalar
|
||||
}
|
||||
}
|
||||
|
||||
// ── Autocomplete registry ─────────────────────────────────
|
||||
inventory::submit!(crate::command::CommandRegistration { names: &["TEXTEDIT", "TEDIT", "TEXTEDITMODE"] });
|
||||
Reference in new issue
Block a user