From 92ac3f60e5e590f0a057365a367ba8a8b2b14e65 Mon Sep 17 00:00:00 2001
From: Jonathan <info@devtec.nl>
Date: Tue, 8 Sep 2026 09:04:52 +0200
Subject: [PATCH] Fix crash when overwriting an existing PDF file

Use atomic file operations (write to temp file, then rename) instead of
direct File::create() to avoid crashes when the target PDF is locked by
another process (e.g., open in PDF reader). The new write_pdf_atomically()
function ensures the file is either fully written or left unchanged, with
a clear error message if the file is in use.

Fixes #1062

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/io/pdf_export.rs | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/src/io/pdf_export.rs b/src/io/pdf_export.rs
index 0ff656d13..88911fd21 100644
--- a/src/io/pdf_export.rs
+++ b/src/io/pdf_export.rs
@@ -175,8 +175,7 @@ pub fn export_pdf(
         plot_style,
         options,
     );
-    let mut file = std::fs::File::create(path).map_err(|e| e.to_string())?;
-    file.write_all(&bytes).map_err(|e| e.to_string())
+    write_pdf_atomically(path, &bytes)
 }
 
 /// Export several independently sized pages into one PDF file.
@@ -190,8 +189,27 @@ pub fn export_pdf_pages(
         return Err("No pages were selected.".into());
     }
     let bytes = build_pdf_pages(pages, plot_style);
-    let mut file = std::fs::File::create(path).map_err(|e| e.to_string())?;
-    file.write_all(&bytes).map_err(|e| e.to_string())
+    write_pdf_atomically(path, &bytes)
+}
+
+/// Atomically write PDF bytes to a file. Writes to a temporary file first,
+/// then renames it to the target path to avoid crashes when overwriting
+/// a file that is locked by another process (e.g., PDF reader).
+#[cfg(not(target_arch = "wasm32"))]
+fn write_pdf_atomically(path: &Path, bytes: &[u8]) -> Result<(), String> {
+    let dir = path.parent().unwrap_or_else(|| std::path::Path::new("."));
+    let file_name = path.file_name()
+        .and_then(|n| n.to_str())
+        .ok_or_else(|| "Invalid file path".to_string())?;
+    let temp_path = dir.join(format!(".{}.tmp", file_name));
+
+    let mut file = std::fs::File::create(&temp_path)
+        .map_err(|e| format!("Failed to create temporary PDF file: {}", e))?;
+    file.write_all(bytes)
+        .map_err(|e| format!("Failed to write PDF data: {}", e))?;
+
+    std::fs::rename(&temp_path, path)
+        .map_err(|e| format!("Failed to write PDF file: {} (the file may be open in another application)", e))
 }
 
 /// Show a parented PDF save-file dialog and return the chosen path.