forked from 1b-agent/opencadstudio-upstream
fix(paste): pasted entities land in the current space
The paste kernel added every entity to model space. It now takes the space a new entity goes to: the block being edited, a layout's paper space when no viewport is active, or model space. Fixes #1652 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
5318609db0
commit
e2f558ae4f
4 files changed
+75
-19
No files matched your search
@@ -308,13 +308,23 @@ impl OpenCADStudio {
|
|||||||
// populate_missing_meshes_from_document / bumps … CALLER-SIDE
|
// populate_missing_meshes_from_document / bumps … CALLER-SIDE
|
||||||
let clipboard = self.clipboard.clone();
|
let clipboard = self.clipboard.clone();
|
||||||
let deps = self.clipboard_deps.clone();
|
let deps = self.clipboard_deps.clone();
|
||||||
let owner_override = self.tabs[i].scene.block_edit_block;
|
// Into the space new entities go: the edited block, the layout's
|
||||||
|
// paper space (no viewport active), or model space.
|
||||||
|
let scene = &self.tabs[i].scene;
|
||||||
|
let layout = scene.current_layout.clone();
|
||||||
|
let space = match scene.block_edit_block {
|
||||||
|
Some(block) => PasteSpace::Block(block),
|
||||||
|
None if layout != "Model" && scene.active_viewport.is_none() => {
|
||||||
|
PasteSpace::Layout(&layout)
|
||||||
|
}
|
||||||
|
None => PasteSpace::Model,
|
||||||
|
};
|
||||||
let (by_index, handle_map) = paste_entities_kernel(
|
let (by_index, handle_map) = paste_entities_kernel(
|
||||||
&mut self.tabs[i].scene.document,
|
&mut self.tabs[i].scene.document,
|
||||||
&clipboard,
|
&clipboard,
|
||||||
&deps,
|
&deps,
|
||||||
translate.as_ref(),
|
translate.as_ref(),
|
||||||
owner_override,
|
space,
|
||||||
);
|
);
|
||||||
// Batched equivalent of `add_entity`'s per-add bump (same pattern as
|
// Batched equivalent of `add_entity`'s per-add bump (same pattern as
|
||||||
// `Scene::add_entities`): fresh top-level solids tessellate once here
|
// `Scene::add_entities`): fresh top-level solids tessellate once here
|
||||||
@@ -474,12 +484,22 @@ pub(crate) fn merge_block_defs(doc: &mut codec::CadDocument, blocks: &[crate::ap
|
|||||||
/// `recreate_groups`, `duplicate_parametric_constraints_for`,
|
/// `recreate_groups`, `duplicate_parametric_constraints_for`,
|
||||||
/// `sync_displayed_annotation_context`, undo/dirty/selection/echo/panels).
|
/// `sync_displayed_annotation_context`, undo/dirty/selection/echo/panels).
|
||||||
/// See the per-helper report in `finalize_paste`.
|
/// See the per-helper report in `finalize_paste`.
|
||||||
|
/// Where pasted entities go, the way `Scene::add_entity` routes a new one.
|
||||||
|
#[derive(Clone, Copy)]
|
||||||
|
pub(crate) enum PasteSpace<'a> {
|
||||||
|
Model,
|
||||||
|
/// A layout's paper space, when no viewport of it is active.
|
||||||
|
Layout(&'a str),
|
||||||
|
/// The block definition being edited (BEDIT).
|
||||||
|
Block(Handle),
|
||||||
|
}
|
||||||
|
|
||||||
pub(crate) fn paste_entities_kernel(
|
pub(crate) fn paste_entities_kernel(
|
||||||
doc: &mut codec::CadDocument,
|
doc: &mut codec::CadDocument,
|
||||||
entities: &[codec::EntityType],
|
entities: &[codec::EntityType],
|
||||||
deps: &crate::app::ClipboardDeps,
|
deps: &crate::app::ClipboardDeps,
|
||||||
translate: Option<&crate::command::EntityTransform>,
|
translate: Option<&crate::command::EntityTransform>,
|
||||||
owner_override: Option<Handle>,
|
space: PasteSpace,
|
||||||
) -> (
|
) -> (
|
||||||
Vec<Handle>,
|
Vec<Handle>,
|
||||||
rustc_hash::FxHashMap<Handle, Handle>,
|
rustc_hash::FxHashMap<Handle, Handle>,
|
||||||
@@ -520,7 +540,7 @@ pub(crate) fn paste_entities_kernel(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
add_entity_clone_doc(doc, entity, owner_override)
|
add_entity_clone_doc(doc, entity, space)
|
||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
@@ -584,12 +604,12 @@ pub(crate) fn paste_entities_kernel(
|
|||||||
/// `Scene::add_entity_clone` — fresh inline sub-handles (INSERT attributes,
|
/// `Scene::add_entity_clone` — fresh inline sub-handles (INSERT attributes,
|
||||||
/// 3D-polyline vertices; `reset_clone_subhandles` is `scene`-private so the
|
/// 3D-polyline vertices; `reset_clone_subhandles` is `scene`-private so the
|
||||||
/// two lines are mirrored here), NULL top-level/owner handles, then
|
/// two lines are mirrored here), NULL top-level/owner handles, then
|
||||||
/// `doc.add_entity`. The `entity_mode` default (Model vs paper space) and all
|
/// adds it to `space`. Tessellation/render caching stays caller-side in the
|
||||||
/// tessellation/render caching stay caller-side in the Scene shell.
|
/// Scene shell.
|
||||||
fn add_entity_clone_doc(
|
fn add_entity_clone_doc(
|
||||||
doc: &mut codec::CadDocument,
|
doc: &mut codec::CadDocument,
|
||||||
mut entity: codec::EntityType,
|
mut entity: codec::EntityType,
|
||||||
owner_override: Option<Handle>,
|
space: PasteSpace,
|
||||||
) -> Handle {
|
) -> Handle {
|
||||||
match &mut entity {
|
match &mut entity {
|
||||||
codec::EntityType::Insert(ins) => {
|
codec::EntityType::Insert(ins) => {
|
||||||
@@ -605,8 +625,16 @@ fn add_entity_clone_doc(
|
|||||||
_ => {}
|
_ => {}
|
||||||
}
|
}
|
||||||
entity.common_mut().handle = Handle::NULL;
|
entity.common_mut().handle = Handle::NULL;
|
||||||
entity.common_mut().owner_handle = owner_override.unwrap_or(Handle::NULL);
|
entity.common_mut().owner_handle = Handle::NULL;
|
||||||
doc.add_entity(entity).unwrap_or(Handle::NULL)
|
match space {
|
||||||
|
PasteSpace::Model => doc.add_entity(entity),
|
||||||
|
PasteSpace::Layout(layout) => doc.add_entity_to_layout(entity, layout),
|
||||||
|
PasteSpace::Block(block) => {
|
||||||
|
entity.common_mut().owner_handle = block;
|
||||||
|
doc.add_entity(entity)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
.unwrap_or(Handle::NULL)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Document-level verbatim block-definition recreate: the `&mut CadDocument`
|
/// Document-level verbatim block-definition recreate: the `&mut CadDocument`
|
||||||
@@ -1160,8 +1188,13 @@ mod paste_entities_kernel_tests {
|
|||||||
let mut dst = codec::CadDocument::new();
|
let mut dst = codec::CadDocument::new();
|
||||||
let delta = glam::DVec3::new(5.0, 7.0, 0.0);
|
let delta = glam::DVec3::new(5.0, 7.0, 0.0);
|
||||||
let translate = crate::command::EntityTransform::Translate(delta);
|
let translate = crate::command::EntityTransform::Translate(delta);
|
||||||
let (handles, handle_map) =
|
let (handles, handle_map) = paste_entities_kernel(
|
||||||
paste_entities_kernel(&mut dst, &entities, &deps, Some(&translate), None);
|
&mut dst,
|
||||||
|
&entities,
|
||||||
|
&deps,
|
||||||
|
Some(&translate),
|
||||||
|
crate::app::PasteSpace::Model,
|
||||||
|
);
|
||||||
|
|
||||||
assert_eq!(handles.len(), 1);
|
assert_eq!(handles.len(), 1);
|
||||||
let pasted = handles[0];
|
let pasted = handles[0];
|
||||||
@@ -1194,7 +1227,13 @@ mod paste_entities_kernel_tests {
|
|||||||
let (entities, deps) = copy_to_clipboard_kernel(&seed, &[leader_handle, note]);
|
let (entities, deps) = copy_to_clipboard_kernel(&seed, &[leader_handle, note]);
|
||||||
|
|
||||||
let mut dst = codec::CadDocument::new();
|
let mut dst = codec::CadDocument::new();
|
||||||
let (handles, _) = paste_entities_kernel(&mut dst, &entities, &deps, None, None);
|
let (handles, _) = paste_entities_kernel(
|
||||||
|
&mut dst,
|
||||||
|
&entities,
|
||||||
|
&deps,
|
||||||
|
None,
|
||||||
|
crate::app::PasteSpace::Model,
|
||||||
|
);
|
||||||
|
|
||||||
assert_eq!(handles.len(), 2);
|
assert_eq!(handles.len(), 2);
|
||||||
let pasted_leader = match dst.get_entity(handles[0]) {
|
let pasted_leader = match dst.get_entity(handles[0]) {
|
||||||
@@ -1237,7 +1276,13 @@ mod paste_entities_kernel_tests {
|
|||||||
|
|
||||||
let mut dst = codec::CadDocument::new();
|
let mut dst = codec::CadDocument::new();
|
||||||
let before: Vec<Handle> = dst.objects.keys().copied().collect();
|
let before: Vec<Handle> = dst.objects.keys().copied().collect();
|
||||||
let (handles, _) = paste_entities_kernel(&mut dst, &entities, &deps, None, None);
|
let (handles, _) = paste_entities_kernel(
|
||||||
|
&mut dst,
|
||||||
|
&entities,
|
||||||
|
&deps,
|
||||||
|
None,
|
||||||
|
crate::app::PasteSpace::Model,
|
||||||
|
);
|
||||||
|
|
||||||
assert_eq!(handles.len(), 1);
|
assert_eq!(handles.len(), 1);
|
||||||
let pasted = handles[0];
|
let pasted = handles[0];
|
||||||
@@ -1302,8 +1347,13 @@ mod headless_reuse_proof_tests {
|
|||||||
let mut doc_b = codec::CadDocument::new();
|
let mut doc_b = codec::CadDocument::new();
|
||||||
let translate =
|
let translate =
|
||||||
crate::command::EntityTransform::Translate(glam::DVec3::new(5.0, 7.0, 0.0));
|
crate::command::EntityTransform::Translate(glam::DVec3::new(5.0, 7.0, 0.0));
|
||||||
let (handles, handle_map) =
|
let (handles, handle_map) = paste_entities_kernel(
|
||||||
paste_entities_kernel(&mut doc_b, &entities, &deps, Some(&translate), None);
|
&mut doc_b,
|
||||||
|
&entities,
|
||||||
|
&deps,
|
||||||
|
Some(&translate),
|
||||||
|
crate::app::PasteSpace::Model,
|
||||||
|
);
|
||||||
|
|
||||||
assert_eq!(handles.len(), 1);
|
assert_eq!(handles.len(), 1);
|
||||||
let pasted = handles[0];
|
let pasted = handles[0];
|
||||||
@@ -1389,7 +1439,7 @@ mod headless_reuse_proof_tests {
|
|||||||
&entities,
|
&entities,
|
||||||
&deps,
|
&deps,
|
||||||
None,
|
None,
|
||||||
Some(block_handle),
|
crate::app::PasteSpace::Block(block_handle),
|
||||||
);
|
);
|
||||||
|
|
||||||
assert_eq!(handles.len(), 1);
|
assert_eq!(handles.len(), 1);
|
||||||
|
|||||||
@@ -95,7 +95,7 @@ mod constraint;
|
|||||||
mod dim_edit;
|
mod dim_edit;
|
||||||
|
|
||||||
pub(crate) use clipboard::{
|
pub(crate) use clipboard::{
|
||||||
copy_to_clipboard_kernel, paste_entities_kernel, remap_ext_subtree_reference,
|
copy_to_clipboard_kernel, paste_entities_kernel, remap_ext_subtree_reference, PasteSpace,
|
||||||
};
|
};
|
||||||
|
|
||||||
impl OpenCADStudio {
|
impl OpenCADStudio {
|
||||||
|
|||||||
+1
-1
@@ -9,7 +9,7 @@ pub(crate) mod config;
|
|||||||
pub use automation::{export_headless, serve};
|
pub use automation::{export_headless, serve};
|
||||||
mod annotation_data;
|
mod annotation_data;
|
||||||
mod command_driver;
|
mod command_driver;
|
||||||
pub(crate) use command_driver::{copy_to_clipboard_kernel, paste_entities_kernel};
|
pub(crate) use command_driver::{copy_to_clipboard_kernel, paste_entities_kernel, PasteSpace};
|
||||||
pub(crate) mod commands;
|
pub(crate) mod commands;
|
||||||
pub(crate) mod dim_viewport;
|
pub(crate) mod dim_viewport;
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
|
|||||||
@@ -114,7 +114,13 @@ fn copy_with_dependencies(
|
|||||||
})
|
})
|
||||||
.collect();
|
.collect();
|
||||||
let (entities, deps) = crate::app::copy_to_clipboard_kernel(src, &handles);
|
let (entities, deps) = crate::app::copy_to_clipboard_kernel(src, &handles);
|
||||||
crate::app::paste_entities_kernel(out, &entities, &deps, translate, None);
|
crate::app::paste_entities_kernel(
|
||||||
|
out,
|
||||||
|
&entities,
|
||||||
|
&deps,
|
||||||
|
translate,
|
||||||
|
crate::app::PasteSpace::Model,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Translate every entity of `out` so the overall bounds minimum lands on
|
/// Translate every entity of `out` so the overall bounds minimum lands on
|
||||||
|
|||||||
Reference in new issue
Block a user