From b562ab51e114ccca32487664eb5e73751bc218b0 Mon Sep 17 00:00:00 2001 From: DuBearte <130190089+DuBearte@users.noreply.github.com> Date: Thu, 15 Oct 2026 22:05:55 -0400 Subject: [PATCH] Agent discovery test: the fixture uses a name Windows runs (#1554) (#1575) The search-order test wrote an extensionless codex-acp, which Windows discovery rightly skips; it now writes the first name this platform looks for (codex-acp.exe on Windows, codex-acp elsewhere). Fixes #1554 Co-authored-by: Claude Opus 5.5 --- crates/ui-egui/src/agent_chat/discover.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/ui-egui/src/agent_chat/discover.rs b/crates/ui-egui/src/agent_chat/discover.rs index c7f24c69..1bf100fc 100644 --- a/crates/ui-egui/src/agent_chat/discover.rs +++ b/crates/ui-egui/src/agent_chat/discover.rs @@ -306,8 +306,10 @@ mod tests { let (a, b) = (root.join("a"), root.join("b")); std::fs::create_dir_all(&a).unwrap(); std::fs::create_dir_all(&b).unwrap(); - std::fs::write(b.join("codex-acp"), "").unwrap(); - assert_eq!(find_in("codex-acp", &[a.clone(), b.clone()]), Some(b.join("codex-acp"))); + // A name this platform runs: Windows looks only for `.exe`/`.cmd`/`.bat` (#1554). + let name = names_for("codex-acp", cfg!(windows)).remove(0); + std::fs::write(b.join(&name), "").unwrap(); + assert_eq!(find_in("codex-acp", &[a.clone(), b.clone()]), Some(b.join(name))); assert_eq!(find_in("gemini", &[a, b]), None); let _ = std::fs::remove_dir_all(root); }