1b-agent/OneCAD
1
0 Fork 0
forked from 1b-agent/solidcraft-upstream
Code Pull Requests Activity

Sketch on every side wall of one sketch extruded up and down (#957)

Browse Source 
* Name a side drawn on several sketch curves by all of them

An extrude named each side wall after the one sketch curve its profile
segment lies on. A wall along two coincident lines (squares drawn edge to
edge) or along collinear lines merged into one profile segment had no
single curve, so it was named from geometry and could not carry a sketch
attachment. One sketch extruded up and down and joined (the logo) refused
a sketch on every one of its side walls.

Such a side is now named by every curve it lies on, in sketch order: the
first is its name, the others aliases. The set is fixed by the sketch, so
the name is exact. The refusal message no longer blames merged faces.

Adds the reported logo design and a synthetic up-and-down join to the
action-matrix designs, and a regression test that sketches and extrudes on
every flat face, fresh and after save and reopen.

Fixes #954

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* Action matrix: record the up-and-down join designs

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
This commit is contained in:
bherbruckandClaude Opus 5.5 authored and GitHub committed 2026-10-14 01:00:04 -04:00
1 parent 9f76cca8b4
commit ea23401710
9 files changed
+305 -13
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

docs/action-matrix.md
+5 -2
View File
@@ -44,11 +44,14 @@ lists which still fail; skip `action_matrix_` to leave out the matrix itself).
`demo/pi-case`: the Raspberry Pi 4 case of the 0.6 README demo, built through the desktop UI
and saved by `examples/demo/enclosure_ui_mcp.py --story pi-0.6 --save`;
`demo/pi-case-0.8`: the 0.8 README demo's case (`--story pi`), with a rounded rim, engraved
text and a PETG material.
text and a PETG material;
`demo/logo-up-down-join`: the SolidCraft logo as it was reported in #954, one sketch extruded
up and down and joined.
- `typical/*`: [`tests/action_matrix/designs`](../tests/action_matrix/designs/), parts made the
ordinary way: a stacked extrude, a filleted and shelled box, a revolved knob, a plate with a
counterbored hole patterned 3 × 2 and a chamfered outline, a sheet metal L bracket with holes, a
join and a cut of three bodies, a loft on a plate, and a sweep.
join and a cut of three bodies, a loft on a plate, a sweep, and one sketch of squares drawn edge
to edge extruded up and down and joined (`up-down-join`).
## The actions