forked from 1b-agent/opencadstudio-upstream
Selection: report what each pick found while a command gathers objects
Every pick during object selection prints the reference's count line: "N found" for the first pick or a pick that adds nothing, "N found, M total" after it, "N found, N removed, M total" when objects leave the set. It is printed before a command's own filtering, so "N were filtered out" follows it. COUNT reports through it and the ad hoc "object(s) found." / "object(s) added to selection." lines are gone. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
2c062daa03
commit
1e93b16911
27 files changed
+112
-16
No files matched your search
@@ -6553,3 +6553,6 @@ keytips =
|
||||
.hint-tabs = اكتب حرف علامة التبويب · Esc للإغلاق
|
||||
.hint-tab = علامة التبويب { $tab } · Esc للرجوع مستوى واحدًا
|
||||
.hint-items = اكتب حرف العنصر · Esc للرجوع مستوى واحدًا
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = Въведете буква на раздел · Esc затваря
|
||||
.hint-tab = Раздел { $tab } · Esc връща едно ниво назад
|
||||
.hint-items = Въведете буква на елемент · Esc връща едно ниво назад
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6538,3 +6538,6 @@ keytips =
|
||||
.hint-tabs = Zadejte písmeno karty · Esc zavře
|
||||
.hint-tab = Karta { $tab } · Esc o úroveň zpět
|
||||
.hint-items = Zadejte písmeno položky · Esc o úroveň zpět
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6539,3 +6539,6 @@ keytips =
|
||||
.hint-tabs = Buchstaben einer Registerkarte eingeben · Esc schließt
|
||||
.hint-tab = Registerkarte { $tab } · Esc geht eine Ebene zurück
|
||||
.hint-items = Buchstaben eines Elements eingeben · Esc geht eine Ebene zurück
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = Πληκτρολογήστε γράμμα καρτέλας · Το Esc κλείνει
|
||||
.hint-tab = Καρτέλα { $tab } · Το Esc επιστρέφει ένα επίπεδο
|
||||
.hint-items = Πληκτρολογήστε γράμμα στοιχείου · Το Esc επιστρέφει ένα επίπεδο
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6540,3 +6540,6 @@ keytips =
|
||||
.hint-tabs = Type a tab letter · Esc closes
|
||||
.hint-tab = { $tab } tab · Esc goes back one level
|
||||
.hint-items = Type an item letter · Esc goes back one level
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = Escriba la letra de una ficha · Esc cierra
|
||||
.hint-tab = Ficha { $tab } · Esc retrocede un nivel
|
||||
.hint-items = Escriba la letra de un elemento · Esc retrocede un nivel
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6538,3 +6538,6 @@ keytips =
|
||||
.hint-tabs = Kirjoita välilehden kirjain · Esc sulkee
|
||||
.hint-tab = Välilehti { $tab } · Esc palaa tason taaksepäin
|
||||
.hint-items = Kirjoita kohteen kirjain · Esc palaa tason taaksepäin
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = Tapez la lettre d'un onglet · Échap ferme
|
||||
.hint-tab = Onglet { $tab } · Échap remonte d'un niveau
|
||||
.hint-items = Tapez la lettre d'un élément · Échap remonte d'un niveau
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6529,3 +6529,6 @@ keytips =
|
||||
.hint-tabs = टैब का अक्षर टाइप करें · Esc बंद करता है
|
||||
.hint-tab = { $tab } टैब · Esc एक स्तर पीछे जाता है
|
||||
.hint-items = आइटम का अक्षर टाइप करें · Esc एक स्तर पीछे जाता है
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6525,3 +6525,6 @@ keytips =
|
||||
.hint-tabs = Írja be a lap betűjét · Az Esc bezár
|
||||
.hint-tab = { $tab } lap · Az Esc egy szinttel visszalép
|
||||
.hint-items = Írja be az elem betűjét · Az Esc egy szinttel visszalép
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6540,3 +6540,6 @@ keytips =
|
||||
.hint-tabs = Digitare la lettera di una scheda · Esc chiude
|
||||
.hint-tab = Scheda { $tab } · Esc torna indietro di un livello
|
||||
.hint-items = Digitare la lettera di un elemento · Esc torna indietro di un livello
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6529,3 +6529,6 @@ keytips =
|
||||
.hint-tabs = タブの文字を入力 · Esc で閉じる
|
||||
.hint-tab = { $tab } タブ · Esc で 1 つ上に戻る
|
||||
.hint-items = 項目の文字を入力 · Esc で 1 つ上に戻る
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6540,3 +6540,6 @@ keytips =
|
||||
.hint-tabs = 탭 문자를 입력하십시오 · Esc로 닫기
|
||||
.hint-tab = { $tab } 탭 · Esc로 한 단계 뒤로
|
||||
.hint-items = 항목 문자를 입력하십시오 · Esc로 한 단계 뒤로
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = ພິມຕົວອັກສອນແຖບ · Esc ປິດ
|
||||
.hint-tab = ແຖບ { $tab } · Esc ກັບຄືນໜຶ່ງລະດັບ
|
||||
.hint-items = ພິມຕົວອັກສອນລາຍການ · Esc ກັບຄືນໜຶ່ງລະດັບ
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6539,3 +6539,6 @@ keytips =
|
||||
.hint-tabs = Typ de letter van een tabblad · Esc sluit
|
||||
.hint-tab = Tabblad { $tab } · Esc gaat één niveau terug
|
||||
.hint-items = Typ de letter van een item · Esc gaat één niveau terug
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6540,3 +6540,6 @@ keytips =
|
||||
.hint-tabs = Wpisz literę karty · Esc zamyka
|
||||
.hint-tab = Karta { $tab } · Esc cofa o jeden poziom
|
||||
.hint-items = Wpisz literę elementu · Esc cofa o jeden poziom
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6541,3 +6541,6 @@ keytips =
|
||||
.hint-tabs = Digite a letra de uma guia · Esc fecha
|
||||
.hint-tab = Guia { $tab } · Esc volta um nível
|
||||
.hint-items = Digite a letra de um item · Esc volta um nível
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6542,3 +6542,6 @@ keytips =
|
||||
.hint-tabs = Введите букву вкладки · Esc закрывает
|
||||
.hint-tab = Вкладка { $tab } · Esc — на уровень назад
|
||||
.hint-items = Введите букву элемента · Esc — на уровень назад
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6462,3 +6462,6 @@ keytips =
|
||||
.hint-tabs = Sekme harfini yazın · Esc kapatır
|
||||
.hint-tab = { $tab } sekmesi · Esc bir düzey geri
|
||||
.hint-items = Öğe harfini yazın · Esc bir düzey geri
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ bulundu, __ocs_fmt_1__ çıkarıldı, toplam __ocs_fmt_2__
|
||||
@@ -6524,3 +6524,6 @@ keytips =
|
||||
.hint-tabs = 键入选项卡字母 · Esc 关闭
|
||||
.hint-tab = { $tab } 选项卡 · Esc 返回上一级
|
||||
.hint-items = 键入项目字母 · Esc 返回上一级
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -6536,3 +6536,6 @@ keytips =
|
||||
.hint-tabs = 輸入索引標籤字母 · Esc 關閉
|
||||
.hint-tab = { $tab } 索引標籤 · Esc 返回上一層
|
||||
.hint-items = 輸入項目字母 · Esc 返回上一層
|
||||
|
||||
selection-report =
|
||||
.found-removed-total = __ocs_fmt_0__ found, __ocs_fmt_1__ removed, __ocs_fmt_2__ total
|
||||
@@ -1261,9 +1261,6 @@ impl OpenCADStudio {
|
||||
.into_iter()
|
||||
.map(|(h, _)| h)
|
||||
.collect();
|
||||
let count = handles.len();
|
||||
self.command_line
|
||||
.push_info(crate::tf!("{count} object(s) found.").as_ref());
|
||||
self.feed_command(StepInput::SelectionComplete(selected))
|
||||
}
|
||||
|
||||
|
||||
@@ -574,6 +574,40 @@ impl OpenCADStudio {
|
||||
StepInput::SelectionComplete(kept)
|
||||
}
|
||||
|
||||
/// What one pick added to (or removed from) a gathering selection, as the
|
||||
/// reference words it: `N found`, `N found, M total`, `N found, N removed,
|
||||
/// M total`. Returns the command's key while it gathers.
|
||||
// ponytail: compares the whole selection before and after, so a pick of an
|
||||
// already chosen object reads `0 found` (the reference says `1 found (1
|
||||
// duplicate)`); pass the pick's own objects through StepInput if needed.
|
||||
fn report_selection_found(&mut self, input: &StepInput) -> Option<usize> {
|
||||
let StepInput::SelectionComplete(handles) = input else {
|
||||
return None;
|
||||
};
|
||||
let command = self.tabs[self.active_tab].active_cmd.as_ref()?;
|
||||
if !command.is_selection_gathering() {
|
||||
return None;
|
||||
}
|
||||
let key = &**command as *const dyn crate::command::CadCommand as *const () as usize;
|
||||
let previous: rustc_hash::FxHashSet<Handle> = match &self.selection_report {
|
||||
Some((k, previous)) if *k == key => previous.iter().copied().collect(),
|
||||
_ => Default::default(),
|
||||
};
|
||||
let now: rustc_hash::FxHashSet<Handle> = handles.iter().copied().collect();
|
||||
let found = now.difference(&previous).count();
|
||||
let removed = previous.difference(&now).count();
|
||||
let total = now.len();
|
||||
let line = if removed > 0 {
|
||||
crate::tf!("{removed} found, {removed} removed, {total} total")
|
||||
} else if found == 0 || previous.is_empty() {
|
||||
crate::tf!("{found} found")
|
||||
} else {
|
||||
crate::tf!("{found} found, {total} total")
|
||||
};
|
||||
self.command_line.push_info(line.as_ref());
|
||||
Some(key)
|
||||
}
|
||||
|
||||
/// `feed_command`, also reporting whether the step actually took the input.
|
||||
/// Only a `Text` token can come back unclaimed (`on_text_input` returning
|
||||
/// `None`), which is what lets the caller read it as something else — a
|
||||
@@ -582,6 +616,7 @@ impl OpenCADStudio {
|
||||
&mut self,
|
||||
input: StepInput,
|
||||
) -> (Task<Message>, bool) {
|
||||
let gathering = self.report_selection_found(&input);
|
||||
// A command that takes associative dimensions only keeps just those:
|
||||
// the rest leave the selection and the count of what went is reported,
|
||||
// as the reference does while gathering.
|
||||
@@ -589,6 +624,9 @@ impl OpenCADStudio {
|
||||
let input = self.filter_block_reference_selection(input);
|
||||
let input = self.filter_locked_point_cloud_selection(input);
|
||||
let input = self.filter_command_entity_selection(input);
|
||||
if let (Some(key), StepInput::SelectionComplete(kept)) = (gathering, &input) {
|
||||
self.selection_report = Some((key, kept.clone()));
|
||||
}
|
||||
// XCLIP / CLIP learn which chosen references carry a clip already.
|
||||
{
|
||||
let i = self.active_tab;
|
||||
@@ -1045,12 +1083,9 @@ impl OpenCADStudio {
|
||||
);
|
||||
return Some(Task::none());
|
||||
}
|
||||
let count = add.len();
|
||||
for h in add {
|
||||
self.tabs[i].scene.select_entity(h, false);
|
||||
}
|
||||
self.command_line
|
||||
.push_info(crate::tf!("{count} object(s) added to selection.").as_ref());
|
||||
self.refresh_properties();
|
||||
let handles: Vec<Handle> = self.tabs[i]
|
||||
.scene
|
||||
|
||||
@@ -796,6 +796,9 @@ pub(super) struct OpenCADStudio {
|
||||
block_freq: std::collections::HashMap<String, u32>,
|
||||
/// BLOCKMRULIST: how many recent blocks the palette keeps (0–100).
|
||||
pub(crate) block_mru_list: u8,
|
||||
/// The selection the gathering command had after the last pick (keyed by
|
||||
/// the command), for the `N found, M total` line.
|
||||
pub(crate) selection_report: Option<(usize, Vec<codec::Handle>)>,
|
||||
/// The Edit Reference dialog's remembered settings.
|
||||
pub(crate) refedit_options: crate::app::settings::RefEditOptions,
|
||||
/// BLOCKREDEFINEMODE (0–2).
|
||||
@@ -4682,6 +4685,7 @@ impl OpenCADStudio {
|
||||
block_mru: Vec::new(),
|
||||
block_freq: std::collections::HashMap::new(),
|
||||
block_mru_list: 50,
|
||||
selection_report: None,
|
||||
refedit_options: Default::default(),
|
||||
block_redefine_mode: 1,
|
||||
block_navigate: ".".to_string(),
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
|
||||
pub(super) fn message_attribute(source: &str) -> Option<(&'static str, &'static str)> {
|
||||
match source {
|
||||
"{removed} found, {removed} removed, {total} total" => Some(("selection-report", "found-removed-total")),
|
||||
"Add to Working Set" => Some(("ref-edit", "add-to-working-set")),
|
||||
"Remove from Working Set" => Some(("ref-edit", "remove-from-working-set")),
|
||||
"Select reference:" => Some(("ref-edit", "select-reference")),
|
||||
|
||||
@@ -158,17 +158,10 @@ impl CadCommand for CountCommand {
|
||||
}
|
||||
|
||||
fn on_selection_complete(&mut self, handles: Vec<Handle>) -> CmdResult {
|
||||
// The selection arrives whole after every pick: `1 found`, then
|
||||
// `1 found, 2 total`.
|
||||
let found = handles.iter().filter(|h| !self.targets.contains(h)).count();
|
||||
let first = self.targets.is_empty();
|
||||
// The selection arrives whole after every pick; the driver reports
|
||||
// what each pick found.
|
||||
self.targets = handles;
|
||||
let total = self.targets.len();
|
||||
CmdResult::ReportMeasurement(if first {
|
||||
crate::tf!("{found} found").into_owned()
|
||||
} else {
|
||||
crate::tf!("{found} found, {total} total").into_owned()
|
||||
})
|
||||
CmdResult::NeedPoint
|
||||
}
|
||||
|
||||
fn needs_entity_pick(&self) -> bool {
|
||||
|
||||
Reference in new issue
Block a user