Selection: report what each pick found while a command gathers objects

Every pick during object selection prints the reference's count line:
"N found" for the first pick or a pick that adds nothing, "N found,
M total" after it, "N found, N removed, M total" when objects leave the
set. It is printed before a command's own filtering, so "N were filtered
out" follows it. COUNT reports through it and the ad hoc
"object(s) found." / "object(s) added to selection." lines are gone.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
ramox81andClaude Opus 5.5 committed 2026-10-14 13:27:44 +03:00
1 parent 2c062daa03
commit 1e93b16911
27 files changed
+112 -16

No files matched your search

-3
View File
@@ -1261,9 +1261,6 @@ impl OpenCADStudio {
.into_iter()
.map(|(h, _)| h)
.collect();
let count = handles.len();
self.command_line
.push_info(crate::tf!("{count} object(s) found.").as_ref());
self.feed_command(StepInput::SelectionComplete(selected))
}
+38 -3
View File
@@ -574,6 +574,40 @@ impl OpenCADStudio {
StepInput::SelectionComplete(kept)
}
/// What one pick added to (or removed from) a gathering selection, as the
/// reference words it: `N found`, `N found, M total`, `N found, N removed,
/// M total`. Returns the command's key while it gathers.
// ponytail: compares the whole selection before and after, so a pick of an
// already chosen object reads `0 found` (the reference says `1 found (1
// duplicate)`); pass the pick's own objects through StepInput if needed.
fn report_selection_found(&mut self, input: &StepInput) -> Option<usize> {
let StepInput::SelectionComplete(handles) = input else {
return None;
};
let command = self.tabs[self.active_tab].active_cmd.as_ref()?;
if !command.is_selection_gathering() {
return None;
}
let key = &**command as *const dyn crate::command::CadCommand as *const () as usize;
let previous: rustc_hash::FxHashSet<Handle> = match &self.selection_report {
Some((k, previous)) if *k == key => previous.iter().copied().collect(),
_ => Default::default(),
};
let now: rustc_hash::FxHashSet<Handle> = handles.iter().copied().collect();
let found = now.difference(&previous).count();
let removed = previous.difference(&now).count();
let total = now.len();
let line = if removed > 0 {
crate::tf!("{removed} found, {removed} removed, {total} total")
} else if found == 0 || previous.is_empty() {
crate::tf!("{found} found")
} else {
crate::tf!("{found} found, {total} total")
};
self.command_line.push_info(line.as_ref());
Some(key)
}
/// `feed_command`, also reporting whether the step actually took the input.
/// Only a `Text` token can come back unclaimed (`on_text_input` returning
/// `None`), which is what lets the caller read it as something else — a
@@ -582,6 +616,7 @@ impl OpenCADStudio {
&mut self,
input: StepInput,
) -> (Task<Message>, bool) {
let gathering = self.report_selection_found(&input);
// A command that takes associative dimensions only keeps just those:
// the rest leave the selection and the count of what went is reported,
// as the reference does while gathering.
@@ -589,6 +624,9 @@ impl OpenCADStudio {
let input = self.filter_block_reference_selection(input);
let input = self.filter_locked_point_cloud_selection(input);
let input = self.filter_command_entity_selection(input);
if let (Some(key), StepInput::SelectionComplete(kept)) = (gathering, &input) {
self.selection_report = Some((key, kept.clone()));
}
// XCLIP / CLIP learn which chosen references carry a clip already.
{
let i = self.active_tab;
@@ -1045,12 +1083,9 @@ impl OpenCADStudio {
);
return Some(Task::none());
}
let count = add.len();
for h in add {
self.tabs[i].scene.select_entity(h, false);
}
self.command_line
.push_info(crate::tf!("{count} object(s) added to selection.").as_ref());
self.refresh_properties();
let handles: Vec<Handle> = self.tabs[i]
.scene
+4
View File
@@ -796,6 +796,9 @@ pub(super) struct OpenCADStudio {
block_freq: std::collections::HashMap<String, u32>,
/// BLOCKMRULIST: how many recent blocks the palette keeps (0–100).
pub(crate) block_mru_list: u8,
/// The selection the gathering command had after the last pick (keyed by
/// the command), for the `N found, M total` line.
pub(crate) selection_report: Option<(usize, Vec<codec::Handle>)>,
/// The Edit Reference dialog's remembered settings.
pub(crate) refedit_options: crate::app::settings::RefEditOptions,
/// BLOCKREDEFINEMODE (0–2).
@@ -4682,6 +4685,7 @@ impl OpenCADStudio {
block_mru: Vec::new(),
block_freq: std::collections::HashMap::new(),
block_mru_list: 50,
selection_report: None,
refedit_options: Default::default(),
block_redefine_mode: 1,
block_navigate: ".".to_string(),
+1
View File
@@ -3,6 +3,7 @@
pub(super) fn message_attribute(source: &str) -> Option<(&'static str, &'static str)> {
match source {
"{removed} found, {removed} removed, {total} total" => Some(("selection-report", "found-removed-total")),
"Add to Working Set" => Some(("ref-edit", "add-to-working-set")),
"Remove from Working Set" => Some(("ref-edit", "remove-from-working-set")),
"Select reference:" => Some(("ref-edit", "select-reference")),
+3 -10
View File
@@ -158,17 +158,10 @@ impl CadCommand for CountCommand {
}
fn on_selection_complete(&mut self, handles: Vec<Handle>) -> CmdResult {
// The selection arrives whole after every pick: `1 found`, then
// `1 found, 2 total`.
let found = handles.iter().filter(|h| !self.targets.contains(h)).count();
let first = self.targets.is_empty();
// The selection arrives whole after every pick; the driver reports
// what each pick found.
self.targets = handles;
let total = self.targets.len();
CmdResult::ReportMeasurement(if first {
crate::tf!("{found} found").into_owned()
} else {
crate::tf!("{found} found, {total} total").into_owned()
})
CmdResult::NeedPoint
}
fn needs_entity_pick(&self) -> bool {