Remove comments that repeat association operations

This commit is contained in:
Christopher Overbeck committed 2026-09-15 16:03:17 -05:00
1 parent 27967e0433
commit 4816652c1f
4 files changed
+2 -28

No files matched your search

-2
View File
@@ -567,8 +567,6 @@ impl Scene {
viewport.view_target.x = center.x;
viewport.view_target.y = center.y;
viewport.view_target.z = center.z;
// Panning a viewport moves model geometry across the sheet; the
// dimensions drawn through it follow.
self.notify_viewport_changed(handle);
} else {
self.camera.borrow_mut().target = center;
-4
View File
@@ -730,10 +730,6 @@ impl Scene {
// Complete group copies record their new Group objects and dictionary
// entry as targeted object deltas inside copy_complete_groups.
self.copy_complete_groups(&handle_map);
// A dimension copied together with everything it measures (its
// viewport, its block path and its source) keeps an association, with
// every handle remapped onto the copies. Copied on its own it keeps
// none — see `copy_dimension_associations`.
self.copy_dimension_associations(&handle_map);
// The copies are new handles (natural memo misses, tessellated fresh)
// and reference only already-cached blocks — no block defn changes.
-10
View File
@@ -265,8 +265,6 @@ impl Scene {
vp.view_height = eff_h;
}
}
// A viewport's view changed, so every dimension drawn on the
// sheet through it has to be re-placed and re-measured.
self.notify_viewport_changed(vp_handle);
}
@@ -358,8 +356,6 @@ impl Scene {
vp.view_target.y += model_delta.y as f64;
vp.view_target.z += model_delta.z as f64;
}
// A viewport's view changed, so every dimension drawn on the
// sheet through it has to be re-placed and re-measured.
self.notify_viewport_changed(vp_handle);
}
@@ -410,8 +406,6 @@ impl Scene {
}
}
}
// A viewport's view changed, so every dimension drawn on the
// sheet through it has to be re-placed and re-measured.
self.notify_viewport_changed(vp_handle);
}
@@ -490,8 +484,6 @@ impl Scene {
vp.view_direction.z = dir.z as f64;
vp.twist_angle = twist;
}
// Twisting a viewport rotates model geometry on the sheet; the
// dimensions drawn through it follow.
self.notify_viewport_changed(vp_handle);
}
@@ -537,8 +529,6 @@ impl Scene {
changed = true;
}
if changed {
// The view (and with it the sheet placement of everything drawn
// through this viewport) moved.
self.notify_viewport_changed(vp_handle);
}
changed
+2 -12
View File
@@ -93,15 +93,8 @@ pub struct SnapResult {
/// query, never by the engine itself.
pub viewport: Option<Handle>,
/// Owning entity of the geometry the snap landed on, when the engine could
/// attribute the feature to a wire.
///
/// This is whatever the *wire* carries, which for anything drawn from a
/// block is the **top-level INSERT's** handle — nested inserts included,
/// because `block_cache` stamps the host insert's name onto every
/// expanded and clipped sub-wire. Resolving that to the inner entity plus
/// the instance path needs the document and the accepted model point, so
/// it happens once at accept time, in
/// `OpenCADStudio::resolve_source_block_path`, which fills
/// attribute the feature to a wire. Block sub-entities report the top-level
/// INSERT handle; the block path is resolved later by
/// [`crate::scene::viewport_ref::SnapSourceRef::block_path`].
pub source: Option<DimensionAssociationSource>,
/// Second real object at an intersection, when both objects are known.
@@ -119,9 +112,6 @@ impl SnapResult {
/// Entity handle carried by a wire (`WireModel::name` is the decimal handle
/// value). Returns `None` for preview / interim wires with a symbolic name.
///
/// For block geometry the value is the top-level INSERT handle, never the
/// inner entity: see [`SnapResult::source`].
#[inline]
pub(crate) fn wire_source(wire: &WireModel) -> Option<DimensionAssociationSource> {
wire.name