fix(ucs): object snap tracking rays follow the active UCS

OTRACK alignment rays (0°/90° and polar steps, plus the polar pencil from
the last point) were built along world X/Y. They now rotate with the
active UCS via a Mat4 passed into otrack_snap (scene.viewcube_ucs_mat() —
the UCS in model space, identity in paper), so tracking lines and the
intersection lock align to the user's coordinate system like ortho,
polar, and the grid. sync_ucs_to_scene now reuses UcsXform::rotation_mat.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
Hakan SevenandClaude Opus 4.8 committed 2026-06-22 11:17:55 +03:00
1 parent 98142ee4af
commit 2509396ba0
4 files changed
+21 -10

No files matched your search

+1 -7
View File
@@ -192,13 +192,7 @@ impl DocumentTab {
/// Push the active UCS rotation into the scene so the ViewCube composes with
/// it. Call after any change to `active_ucs`.
pub(super) fn sync_ucs_to_scene(&mut self) {
let (_, x, y, z) = self.ucs_xform().axes();
self.scene.viewcube_ucs = glam::Mat4::from_cols(
x.extend(0.0),
y.extend(0.0),
z.extend(0.0),
glam::Vec4::W,
);
self.scene.viewcube_ucs = self.ucs_xform().rotation_mat();
}
pub(super) fn new_drawing(n: usize) -> Self {
+11
View File
@@ -118,6 +118,17 @@ impl UcsXform {
pub(super) fn axes(&self) -> (glam::Vec3, glam::Vec3, glam::Vec3, glam::Vec3) {
(self.origin, self.x, self.y, self.z)
}
/// UCS→world rotation matrix (columns = UCS axes). For consumers that take
/// a `Mat4` rotation directly (ViewCube, OTRACK ray directions).
pub(super) fn rotation_mat(&self) -> glam::Mat4 {
glam::Mat4::from_cols(
self.x.extend(0.0),
self.y.extend(0.0),
self.z.extend(0.0),
glam::Vec4::W,
)
}
}
// ── UCS ↔ WCS transforms (thin wrappers over `UcsXform`) ────────────────────
+4 -1
View File
@@ -2839,12 +2839,14 @@ impl OpenCADStudio {
} else {
None
};
let ucs = self.tabs[i].scene.viewcube_ucs_mat();
self.snapper.otrack_snap(
cursor_world,
view_proj,
bounds,
step,
self.last_point,
ucs,
)
} else {
None
@@ -3464,8 +3466,9 @@ impl OpenCADStudio {
} else {
None
};
let ucs = self.tabs[i].scene.viewcube_ucs_mat();
self.snapper
.otrack_snap(raw, vp_mat, bounds, step, self.last_point)
.otrack_snap(raw, vp_mat, bounds, step, self.last_point, ucs)
} else {
None
};
+5 -2
View File
@@ -263,6 +263,9 @@ impl Snapper {
bounds: iced::Rectangle,
polar_step_deg: Option<f32>,
last_point: Option<Vec3>,
// UCS→world rotation: tracking rays run along the UCS axes, matching
// ortho/polar. Identity = world-aligned rays.
ucs: glam::Mat4,
) -> Option<OtrackHit> {
if !self.otrack_enabled || self.tracking_points.is_empty() {
return None;
@@ -307,7 +310,7 @@ impl Snapper {
let ar = adeg.to_radians();
rays.push(Ray {
origin: tp,
dir: Vec3::new(ar.cos(), ar.sin(), 0.0),
dir: ucs.transform_vector3(Vec3::new(ar.cos(), ar.sin(), 0.0)),
group: gi,
});
}
@@ -322,7 +325,7 @@ impl Snapper {
let ar = a.to_radians();
rays.push(Ray {
origin: lp,
dir: Vec3::new(ar.cos(), ar.sin(), 0.0),
dir: ucs.transform_vector3(Vec3::new(ar.cos(), ar.sin(), 0.0)),
group: POLAR_GROUP,
});
a += step;