Commit Graph
3576 Commits
Author SHA1 Message Date
Hakan Seven 279288ab71 Merge pull request #1276 from CiberNin/fix/windows-printers 2026-09-15 12:29:27 +03:00
Hakan Seven aca00c6da2 Merge pull request #1274 from CiberNin/fix/viewport-pixel-placement 2026-09-15 12:29:27 +03:00
Hakan Seven 48a734ba9b Merge pull request #1272 from kevin9327/fix/linear-dimension-off-world-z 2026-09-15 12:29:27 +03:00
Hakan Seven a6bc50c8d3 Merge pull request #1265 from ramox81/codex/modify-menu 2026-09-15 12:29:27 +03:00
Hakan Seven 567c4b5189 Merge pull request #1264 from ramox81/codex/draw-menu 2026-09-15 12:29:27 +03:00
Hakan Seven 801e00e940 Merge pull request #1263 from ramox81/codex/annotation-menu 2026-09-15 12:29:27 +03:00
ramox81 b9ef0e3286 Match default automatic constraint set 2026-09-15 12:09:59 +03:00
Hakan Seven dfe8b77cca Merge PR #1280 and expose constraint value visibility 2026-09-15 11:55:05 +03:00
Hakan Seven adc8555394 Merge PR #1279 and complete parametric UI actions 2026-09-15 11:48:35 +03:00
ramox81 66be530655 Complete automatic constraint behavior 2026-09-15 11:47:28 +03:00
Hakan Seven 06fcf09ae3 Integrate standard parametric PR fixes 2026-09-15 10:43:00 +03:00
Hakan Seven d738ebfcc6 Standardize parametric constraints and interoperability 2026-09-15 03:19:52 +03:00
Felix RiestraandClaude Sonnet 5 ed2e0fbc4a Wire up the Properties panel's Parameters section
PropValue::ParamRow/ParamAddRow, the PropParamInput/Commit/Delete/AddNew
messages, their command_driver handlers (on_prop_param_commit/_delete/
_add_new, resolve_named_parameter_edit), and their render functions all
already existed — but nothing ever constructed the "Parameters" section
that would route data to them, so the whole inline add/rename/redefine/
delete workflow was unreachable from the UI. Adds that missing section
to the no-selection page in refresh_properties, alongside a new
PropValue::ParamsVisibilityToggle header row (mirrors the existing
show_constraint_values setting) for toggling whether constraint pills
show their driven value/parameter name.

Users can now manage named parameters inline in the Properties panel
(live resolved values, add/rename/redefine/delete) as an alternative to
the separate PARAMETERS modal, which continues to work unchanged.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-15 01:26:48 +02:00
Felix RiestraandClaude Sonnet 5 0f739b459d Add bounding-box object alignment (ALIGNLEFT/TOP/etc.), ported from Mac2CAM
Six one-shot alignment commands for the current selection —
ALIGNLEFT/ALIGNHCENTER/ALIGNRIGHT/ALIGNTOP/ALIGNVCENTER/ALIGNBOTTOM —
distinct from the existing point-picking ALIGN/ALIGN3D command: each
nudges every selected object (or complete group, via new
Scene::selected_object_units) so its bounding-box edge/center lines up
with the extreme edge/center already present in the selection, closer
to a word processor's "align objects" than AutoCAD's 3-point ALIGN.

Wired as plain one-click Tool entries in the Modify extension panel,
next to the existing ALIGN entry, matching that panel's flat-list
convention (no point prompts, so no dropdown submenu needed).

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-15 01:08:41 +02:00
Felix RiestraandClaude Sonnet 5 59ae38ae1a Add per-constraint delete; fix named-parameter reference bugs
Constraint delete: a Properties-panel row delete button, viewport
click-to-select on a constraint glyph pill with Delete-key support, and a
right-click "Delete Constraint" menu item — all routed through one
undoable Scene::selected_constraint-aware path.

Fixes two named-parameter bugs found while testing that feature:
- DIMCONSTRAINT: a parameter named like a mode-switch keyword ("r", "d",
  "a", "x", "y") could never be referenced, since the keyword check ran
  before the parameter-name check.
- PARAMETERS modal Apply rebuilt Scene::named_parameters but never
  refreshed the Properties panel, leaving renamed/deleted rows stale
  until an unrelated refresh (e.g. a selection change) happened to occur.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-15 01:08:34 +02:00
Christopher Overbeck e16ab7c86f Preserve narrow spline clearances when tessellating solid fills
Recover failed small spline boundaries with the kernel chord-error
sampler, using the same coordinate frame as the fill mesh. Preserve
source curves and enforce recovery and total hatch vertex limits.

Fixes #1268
2026-09-14 17:09:33 -05:00
kevin9327andClaude Opus 5 743a25b76a fix(plot-style): keep custom lineweights at full precision when saving
Saving a plot style table wrote every value of its custom lineweight table
with two decimals, so a pen such as 0.035 mm came back as 0.04 mm after a
save and reload, and every color using it plotted with the wrong weight.

Write the lineweights in full, through the same formatting the scale factor
already uses, which keeps the decimal point on a whole value.

Co-Authored-By: Claude Opus 5 <[email protected]>
2026-09-15 07:09:27 +09:00
Christopher Overbeck 37cfa06b02 Preserve fractional viewport placement when compositing paper space
Keep fractional raster placement and matching integer texture coverage
through compositing. Apply parent clipping without changing the scale.

Fixes #1267
2026-09-14 17:07:57 -05:00
Christopher Overbeck c93cc17592 Include bitmap images in PDF plots, preview, and printing
Include decoded IMAGE/OLE content in the shared PDF plotting path,
with clipping, transforms, transparency, draw order, and resource reuse.
Use named page content for export and printing.

Fixes #1266
2026-09-14 17:07:57 -05:00
Christopher Overbeck f85b23bf74 Enumerate installed Windows printers in the plot dialog
Populate the plot-dialog printer list from the Windows spooler cache.
Validate record counts and UTF-16 name bounds before reading the buffer.

Refs #1261
2026-09-14 17:07:56 -05:00
kevin9327andClaude Opus 5 c13e86b87d fix(dimension): draw linear and aligned dimensions in their own plane off world Z
A linear or aligned dimension whose normal is not world Z was drawn and
exploded as if it lay in world XY. The builders read the offset and the
extension directions in XY only, so a dimension turned into a working plane
such as XZ lost its offset (now along Z): the dimension line fell onto the
measured points and the extension lines stuck out along world Y.

Move such a dimension into its own OCS before building it and map the result
back onto its plane, as arc length and large radial dimensions already do,
for both tessellation and EXPLODE.

Co-Authored-By: Claude Opus 5 <[email protected]>
2026-09-15 07:00:47 +09:00
Hakan Seven 753df67ee4 Complete parametric drawing interoperability 2026-09-14 23:51:37 +03:00
ramox81 dfcae61ca7 fix(modify): remove cleanup tab duplicate 2026-09-14 22:01:29 +03:00
ramox81 4ce42f9cdb fix(draw): remove cross-tab extension tools 2026-09-14 22:00:59 +03:00
ramox81 ec14c98f07 fix(annotate): keep tools in their ribbon tab 2026-09-14 21:59:20 +03:00
Hakan Seven 7aff9fa046 ui(parametric): enlarge constraint ribbon tools 2026-09-14 21:18:11 +03:00
ramox81 768eaf5b2d feat(annotate): expose annotation panel tools 2026-09-14 21:05:53 +03:00
Hakan Seven caec8dc53b Merge remote-tracking branch 'origin/main' 2026-09-14 20:24:54 +03:00
Hakan Seven c9350d7b7b fix(web): disable unsupported folder picker 2026-09-14 20:24:34 +03:00
Hakan Seven 6c0badbdc8 fix: resolve annotation pull request findings 2026-09-14 20:16:46 +03:00
Hakan Seven 293d0796fb Merge pull request #1246 2026-09-14 19:58:35 +03:00
Hakan Seven f2fd2ae5ad fix: address open pull request review findings 2026-09-14 19:58:35 +03:00
Hakan Seven 2d20bdd51c Merge pull request #1251 2026-09-14 19:51:57 +03:00
Hakan Seven f79594db38 Merge pull request #1260 2026-09-14 19:49:24 +03:00
Hakan Seven b48157a5af Merge pull request #1258 2026-09-14 19:49:24 +03:00
Hakan Seven 05baa82241 Merge pull request #1256 2026-09-14 19:49:24 +03:00
Hakan Seven 17f345953e Merge pull request #1253 2026-09-14 19:49:24 +03:00
Hakan Seven 61289bfa60 Merge pull request #1252 2026-09-14 19:49:24 +03:00
Hakan Seven b58d21a2c9 Merge pull request #1250 2026-09-14 19:49:24 +03:00
Hakan Seven ddabc2658a Merge pull request #1249 2026-09-14 19:49:24 +03:00
Karim Jerbi a0d784502a feat(ui): modernize DSETTINGS dialog with tabbed layout and action controls
- Redesign drafting settings window to landscape 700x480 proportions while preserving interactive resizing
- Add 7-tab navigation: Snap and Grid, Polar Tracking, Object Snap, 3D Object Snap, Dynamic Input, Quick Properties, and Selection Cycling
- Distribute existing drafting modes, snap options, and isometric tools into their respective tabs
- Implement OK, Apply, and Close action buttons with unsaved changes confirmation guard
2026-09-14 17:45:47 +01:00
Karim Jerbi ddeddeca31 perf(snap): optimize OSNAP cursor tracking broadphase and tangent gating (22.7x speedup)
- Implement zero-allocation InRangeWires stack buffer (up to 16 wires) to eliminate repetitive linear full-scene passes in Snapper::snap
- Add early-exit when cursor hovers whitespace (<1 µs latency)
- Add wire_in_range AABB guard to Tangent snap, cutting ~10,000 redundant 3D-to-screen matrix projections per query
- Add pairwise count guards (>= 2) to Intersection and ApparentIntersection, eliminating 120 KB of heap allocations per query in ApparentIntersection
- Add comprehensive regression tests in snap::ext_tests
- Benchmark gains:
  * Quick mode (1,000 entities): 33.98 µs -> 1.50 µs (22.7x faster, +2,024% throughput)
  * Full mode (5,000 entities): ~165.0 µs -> 7.46 µs (22.1x faster, +2,133% throughput)
2026-09-14 16:12:35 +01:00
ramox81 0cabe113c8 Fix helix height from point input 2026-09-14 17:36:33 +03:00
ramox81 a28a9088d7 Use viewport UCS status fields 2026-09-14 16:57:58 +03:00
ramox81 88839b783a Match active view properties palette 2026-09-14 16:56:48 +03:00
Karim Jerbi 509d746dd0 perf(scene): chunked batch accumulation for spatial InteractionIndex build
Optimize InteractionIndex::build by eliminating per-wire vector allocation churn
and combining wire handle / ordinal resolution:

1. Introduced WireIndexBatch to chunk wires into batches of 256 wires. Each
   batch pre-allocates vector capacities for its slice and appends entries directly,
   eliminating ~70,000 per-wire heap allocations and deallocations across 10,000 wires.
2. Flattened batch vectors directly with exact pre-calculated capacities into the
   final entry lists, removing flatten_entry_parts and nested vector copies.
3. Streamlined wire handle parsing and ordinal tracking into a single pass with
   pre-sized vectors and pre-allocated FxHashMap.

Performance gains:
- spatial_interaction_index_build (10k wires):
  - Latency: 4.88 ms -> 4.01 ms (-17.8%)
  - Mean latency: 4.93 ms -> 4.05 ms (-17.8%)
  - Throughput: 2.05M wires/s -> 2.53M wires/s (+23.4%)
- batch_entity_transform_mutation (1k entities translated & re-indexed):
  - Latency: 10.92 ms -> 8.95 ms (-18.0%)
  - Mean latency: 11.28 ms -> 9.52 ms (-15.6%)
  - Throughput: 92.4k entities/s -> 111.3k entities/s (+20.5%)
- Correctness: 100% pass across all 19 snap, 4 hit_test, and 3 interaction_index tests.
2026-09-14 14:55:18 +01:00
ramox81 7dabc48fd3 Match Region properties palette 2026-09-14 16:16:20 +03:00
ramox81 666b28ffe3 fix(annotate): reject invalid linked ranges 2026-09-14 15:07:51 +03:00
ramox81 a35c996f9f fix(annotate): complete table and data workflows 2026-09-14 14:54:55 +03:00
Karim Jerbi cc1e78cc70 perf(ui): add MRU inline cache to themed_handle for fast icon lookups
Optimize themed_handle in src/ui/icons.rs by adding an inline 2-entry MRU cache
ahead of the full FxHashMap table:

1. Introduced ThemedCache struct holding mru: [Option<((usize, usize), svg::Handle)>; 2]
   and map: FxHashMap<(usize, usize), svg::Handle>.
2. Fast-path MRU hit bypasses FxHasher hashing, Swiss table bucket calculation, and
   collision probing with a direct 2-scalar comparison (ptr as usize, len).
3. Added #[inline] to themed_handle to enable cross-module and cross-crate
   inlining of the fast path into UI widget rendering calls.
4. Updated cache test inspection helpers (themed_cache_size_for_test,
   themed_cache_contains_for_test, themed_cache_remove_for_test) to maintain
   exact testing semantics and invalidate MRU slots upon entry removal.

Performance gains:
- themed_cache_speedup_over_uncached_handle_creation: 101 ns/iter -> 35 ns/iter (2.9x speedup)
- ui_icon_handle_cached: 80.19M lookups/s (12.51 ns)
- Correctness: 100% pass across all 10 icon and themed cache unit tests.
2026-09-14 12:50:43 +01:00